Skip to content

Commit 17f07a5

Browse files
xclaessenirbheek
authored andcommitted
msubprojects: Fix unit tests on Windows
1 parent da72e62 commit 17f07a5

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

mesonbuild/msubprojects.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os, subprocess
22
import argparse
3+
from pathlib import Path
34

45
from . import mlog
56
from .mesonlib import quiet_git, verbose_git, GitException, Popen_safe, MesonException
@@ -338,7 +339,7 @@ def run(options):
338339
for wrap in wraps:
339340
if types and wrap.type not in types:
340341
continue
341-
dirname = os.path.join(subprojects_dir, wrap.directory)
342+
dirname = Path(subprojects_dir, wrap.directory).as_posix()
342343
if not options.subprojects_func(wrap, dirname, options):
343344
failures.append(wrap.name)
344345
if failures:

run_unittests.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9125,13 +9125,13 @@ def ran_in(s):
91259125

91269126
dummy_cmd = ['true']
91279127
out = self._subprojects_cmd(['foreach'] + dummy_cmd)
9128-
self.assertEqual(ran_in(out), sorted(['./subprojects/sub_file', './subprojects/sub_git', './subprojects/sub_git_no_wrap']))
9128+
self.assertEqual(ran_in(out), sorted(['subprojects/sub_file', 'subprojects/sub_git', 'subprojects/sub_git_no_wrap']))
91299129
out = self._subprojects_cmd(['foreach', '--types', 'git,file'] + dummy_cmd)
9130-
self.assertEqual(ran_in(out), sorted(['./subprojects/sub_file', './subprojects/sub_git']))
9130+
self.assertEqual(ran_in(out), sorted(['subprojects/sub_file', 'subprojects/sub_git']))
91319131
out = self._subprojects_cmd(['foreach', '--types', 'file'] + dummy_cmd)
9132-
self.assertEqual(ran_in(out), ['./subprojects/sub_file'])
9132+
self.assertEqual(ran_in(out), ['subprojects/sub_file'])
91339133
out = self._subprojects_cmd(['foreach', '--types', 'git'] + dummy_cmd)
9134-
self.assertEqual(ran_in(out), ['./subprojects/sub_git'])
9134+
self.assertEqual(ran_in(out), ['subprojects/sub_git'])
91359135

91369136
def _clang_at_least(compiler, minver: str, apple_minver: str) -> bool:
91379137
"""

0 commit comments

Comments
 (0)