#37 NeverEnding reader postpones last message #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
Logic of when to fetch next batch, is too different between reader nodes,
for ending, it needs to happen AFTER item BEFORE return, so hasNext can answer
for never-ending, it needs to happen BEFORE item, since it can take forever, which should not be done inside hasNext, which is always true
Also timeout of 3 seconds is just not enough for our poor cluster to not-return empty batch on the first fetch
Also changed default to Ending, so samples can actually be run without blocking on first ocurence of reader
closes #37