Skip to content

Conversation

@ABMC831
Copy link
Collaborator

@ABMC831 ABMC831 commented Jan 27, 2025

Release notes:

  • split never-ending / ending reader implementation thus fixing the bug

Logic of when to fetch next batch, is too different between reader nodes,

for ending, it needs to happen AFTER item BEFORE return, so hasNext can answer

for never-ending, it needs to happen BEFORE item, since it can take forever, which should not be done inside hasNext, which is always true

Also timeout of 3 seconds is just not enough for our poor cluster to not-return empty batch on the first fetch

Also changed default to Ending, so samples can actually be run without blocking on first ocurence of reader

closes #37

@ABMC831 ABMC831 self-assigned this Jan 27, 2025
@ABMC831 ABMC831 requested a review from Zejnilovic January 27, 2025 14:49
@ABMC831 ABMC831 merged commit 9443a19 into master Jan 28, 2025
3 of 4 checks passed
@ABMC831 ABMC831 deleted the bugfix/#37-NeverEnding-reader-postpones-last-message branch January 28, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeverEnding reader postpones last message

3 participants