Make icons path configurable instead of hardcoded #455
+111
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmatta
requested review from
TerranceKhumalo-absa and
korel-san
as code owners
Current unit tests would not fail even if we wouldn't use optional flag when injecting the token. We should properly test case when not having any value injected or the ICONS_PATH token.
TerranceKhumalo-absa
approved these changes
Dec 3, 2025
Collaborator
TerranceKhumalo-absa
left a comment
TerranceKhumalo-absa
left a comment
There was a problem hiding this comment.
Looks good
lukasmatta
deleted the
440-make-icons-path-configurable-instead-of-hardcoded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
ICONS_PATHinjection token to configure custom path for the icons fileCloses #440