Skip to content

Small Nits #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kayanski merged 7 commits into from
Jan 10, 2024
Merged

Small Nits #297

Kayanski merged 7 commits into from
Jan 10, 2024

Conversation

@Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Jan 8, 2024 •
edited
Loading

Added std error to TxHandler::Error

  • Breaking change
    Closes ORC-59

Added better contract logging

Closes ORC-57
Sample logs
image

[2024-01-09T09:46:28Z INFO  Local] Writing daemon state JSON file: "/root/.cw-orchestrator/state_local.json"
[2024-01-09T09:46:28Z INFO  Local] Interacting with testing using address: juno16g2rahf5846rxzp3fwlswy08fz8ccuwk03k57y
[2024-01-09T09:46:28Z INFO  Contract] [local:counter][Upload][START]
[2024-01-09T09:46:28Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:38Z INFO  Transaction] Uploading done: "B84AEF9F3CAC18060036E66F71AC8030EBEA21BC17CDF5A10464CFA4EC036779"
[2024-01-09T09:46:38Z INFO  Contract] [local:counter][Upload][END] code_id 5
[2024-01-09T09:46:38Z INFO  Contract] [local:counter][Instantiate][START]
[2024-01-09T09:46:38Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:48Z INFO  Transaction] Instantiation done: "8B2E2894AAB63E35CF2D21CED65F57B701EF53820C0C87D1F581EBB2B5A865E4"
[2024-01-09T09:46:48Z INFO  Contract] [local:counter][Instantiate][END] juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4
[2024-01-09T09:46:48Z INFO  Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][START] increment
[2024-01-09T09:46:48Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:58Z INFO  Transaction] Execution done: "F6190D05E7A4C8EC636537F5114A789995CFAAB473FB0ADAFF0ACD17408098B0"
[2024-01-09T09:46:58Z INFO  Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][END] increment

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52fab63
Status:🚫  Build failed.

View logs

@Kayanski Kayanski changed the title Some small improvments Add std::error::Error trait bound on TxHandler::Error Jan 8, 2024
@Kayanski Kayanski changed the title Add std::error::Error trait bound on TxHandler::Error Small Nits Jan 9, 2024
@CyberHoward
Copy link
Contributor

CyberHoward commented Jan 9, 2024

Not a huge fan of the START / END

@codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (c087e2f) 65.6% compared to head (904b643) 65.5%.
Report is 1 commits behind head on main.

❗ Current head 904b643 differs from pull request most recent head 4359849. Consider uploading reports for the commit 4359849 to get more accurate results

Additional details and impacted files
Files Coverage Δ
...-orch-core/src/environment/cosmwasm_environment.rs 54.5% <ø> (ø)
...ges/cw-orch-core/src/contract/contract_instance.rs 78.6% <59.6%> (-11.5%) ⬇️

@Buckram123
Copy link
Contributor

Buckram123 commented Jan 9, 2024

Would agree with Howard about [START] and [END]. And would it be possible to align first block? It's currently hard to process(with my eyes)

[2024-01-09T09:46:28Z INFO              Local] Writing daemon state JSON file: "/root/.cw-orchestrator/state_local.json"
[2024-01-09T09:46:28Z INFO              Local] Interacting with testing using address: juno16g2rahf5846rxzp3fwlswy08fz8ccuwk03k57y
[2024-01-09T09:46:28Z INFO           Contract] [local:counter][Upload][START]
[2024-01-09T09:46:28Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:38Z INFO        Transaction] Uploading done: "B84AEF9F3CAC18060036E66F71AC8030EBEA21BC17CDF5A10464CFA4EC036779"
[2024-01-09T09:46:38Z INFO           Contract] [local:counter][Upload][END] code_id 5
[2024-01-09T09:46:38Z INFO           Contract] [local:counter][Instantiate][START]
[2024-01-09T09:46:38Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:48Z INFO        Transaction] Instantiation done: "8B2E2894AAB63E35CF2D21CED65F57B701EF53820C0C87D1F581EBB2B5A865E4"
[2024-01-09T09:46:48Z INFO           Contract] [local:counter][Instantiate][END] juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4
[2024-01-09T09:46:48Z INFO           Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][START] increment
[2024-01-09T09:46:48Z INFO  Transaction Retry] Awaiting TX inclusion in block...
[2024-01-09T09:46:58Z INFO        Transaction] Execution done: "F6190D05E7A4C8EC636537F5114A789995CFAAB473FB0ADAFF0ACD17408098B0"
[2024-01-09T09:46:58Z INFO           Contract] [local:counter][Execute][juno1eyfccmjm6732k7wp4p6gdjwhxjwsvje44j0hfx8nkgrm8fs7vqfs9a4ky4][END] increment

Also not sure if awaiting TX inclusion should be marked with Retry

@Kayanski Kayanski added this to the 0.20 milestone Jan 10, 2024
@Kayanski Kayanski added the breaking This change prompts a major version bump. label Jan 10, 2024
@Kayanski Kayanski merged commit 4cef88c into main Jan 10, 2024
@Kayanski Kayanski deleted the update/small-nits branch January 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking This change prompts a major version bump.

Projects

None yet

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

4 participants

@Kayanski @CyberHoward @Buckram123