Skip to content

Conversation

@Buckram123
Copy link
Contributor

This PR aims to return cosmwasm_std::HexBinary instead of hex encoded String, for checksums


thiserror = { version = "1.0.21" }
sha256 = { version = "1" }
sha2 = { version = "0.10.8" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For using sha2 instead of sha256 - it's lighter(sha2 is dependency of sha256) and returns bytes, instead of String, which is easier to use in pair with HexBinary

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 14, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8f06662
Status: ✅  Deploy successful!
Preview URL: https://4ab33556.cw-orchestrator.pages.dev
Branch Preview URL: https://fix-checksum-should-not-be-s.cw-orchestrator.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (61369ea) 65.4% compared to head (61cfbcb) 65.4%.

❗ Current head 61cfbcb differs from pull request most recent head 8f06662. Consider uploading reports for the commit 8f06662 to get more accurate results

Additional details and impacted files
Files Coverage Δ
packages/cw-orch-core/src/contract/paths.rs 70.0% <100.0%> (+0.7%) ⬆️
...ages/cw-orch-core/src/environment/queriers/wasm.rs 100.0% <100.0%> (ø)
packages/cw-orch-mock/src/queriers/wasm.rs 79.7% <100.0%> (+0.4%) ⬆️
cw-orch-daemon/src/queriers/cosmwasm.rs 47.4% <75.0%> (-0.3%) ⬇️
cw-orch/src/osmosis_test_tube/queriers/wasm.rs 53.3% <83.3%> (+0.3%) ⬆️

@CyberHoward CyberHoward merged commit 9ff0fd7 into main Feb 14, 2024
@CyberHoward CyberHoward deleted the fix/checksum-should-not-be-string branch February 14, 2024 21:32
@Buckram123
Copy link
Contributor Author

@CyberHoward just noticed I forgot to update docs so doc tests are failing 👀

@CyberHoward
Copy link
Contributor

@CyberHoward just noticed I forgot to update docs so doc tests are failing 👀

Can you push a fix to a new pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants