Allow overwriting chain options in Daemon Builder #370
Conversation
Deploying cw-orchestrator with
|
| Latest commit: |
29700a8
|
| Status: | ⚡️ Build in progress... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
cw-orch-daemon/src/sync/builder.rs
Outdated
| // # Optional | ||
| pub(crate) handle: Option<tokio::runtime::Handle>, | ||
| pub(crate) deployment_id: Option<String>, | ||
| pub(crate) additional_grpc_url: Option<String>, |
There was a problem hiding this comment.
| pub(crate) additional_grpc_url: Option<String>, | |
| pub(crate) overwrite_grpc_url: Option<String>, |
There was a problem hiding this comment.
Should either rename this or update the URL logic to add the url to the grpc url list instead of replacing it alltogether.
There was a problem hiding this comment.
We need to be able to replace it in case the current one gives errors (even if we have fallback logic right now)
Choosing for replacing it (works in most cases)
cw-orch-daemon/src/sync/builder.rs
Outdated
| } | ||
|
|
||
| pub fn add_grpc_url(&mut self, url: &str) -> &mut Self { | ||
| self.additional_grpc_url = Some(url.to_string()); |
There was a problem hiding this comment.
| self.additional_grpc_url = Some(url.to_string()); | |
| self.overwrite_grpc_url = Some(url.to_string()); |
cw-orch-daemon/src/sync/builder.rs
Outdated
| // Override gas fee | ||
| override_fee(&mut chain, self.gas_denom.clone(), self.gas_fee); | ||
| // Override grpc_url | ||
| override_grpc_url(&mut chain, self.additional_grpc_url.clone()); |
There was a problem hiding this comment.
| override_grpc_url(&mut chain, self.additional_grpc_url.clone()); | |
| override_grpc_url(&mut chain, self.overwrite_grpc_url.clone()); |
|
stable clippy is failing |
Kayanski
deleted the
nicolas/orc-118-add-overwrite-options-to-daemon-builder
branch
This PR aims at allowing developers to overwrite chain options directly in the daemon Builder.