Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialX 1.36 additions #905

Merged
merged 6 commits into from
Jul 28, 2018
Merged

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jul 25, 2018

New nodes for MaterialX 1.36:

  • transformpoint, transformvector, transformnormal
  • rgbtohsv, hsvtorgb

Also adds to our contributed shader headers:

  • vector4 version of transform (by space name or by matrix)
  • color4 version of transformc (converts the color portion, leaves alpha alone)

@lgritz
Copy link
Collaborator Author

lgritz commented Jul 27, 2018

Amended PR with additional changes:

  • Add new MX 1.36 node "rotate", mark old "rotate2d" as deprecated.

  • Add new MX 1.36 node "hsvadjust", mark old "hueshift" as deprecated.

  • stdosl.h: add a new variant of rotate() that takes just an axis and rotates around the origin using that axis (the other, previously existing, version or rotate() takes two arbitrary points and rotates about the line connecting them).

@lgritz
Copy link
Collaborator Author

lgritz commented Jul 27, 2018

Amended again: add new MX 1.36 "extract" and "separate" nodes.

@lgritz lgritz merged commit 3e3b528 into AcademySoftwareFoundation:master Jul 28, 2018
lgritz added a commit to lgritz/OpenShadingLanguage that referenced this pull request Jul 28, 2018
…ate (AcademySoftwareFoundation#905)

* Add a variant of rotate() that just takes an axis, rotate about the origin.

* MaterialX: add rotate node (new with MaterialX 1.36)

* rotate2d note is kept for back-compatibility, but considered deprecated, since it was dropped from 1.36.

* MaterialX: implement new transformpoint, transformvector, transformnormal nodes

* MaterialX: add new nodes rgbtohsv, hsvtorgb

* MaterialX: add new 1.36 node 'hsvadjust', deprecate 'hueshift'

* MatrialX: Add new 1.36 nodes: extract, separate
@lgritz lgritz deleted the lg-mx2 branch July 28, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant