fix!: Drop next/previous focus properties#288
Merged
Conversation
DataTriny
approved these changes
Aug 29, 2023
Merged
lunixbochs
pushed a commit
to talonvoice/accesskit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided that, as shown in #284, these properties only add unnecessary complexity for GUI toolkit developers. None of the platform adapters use them, and there's probably no way they ever could. The equivalent properties in Chromium are only used by ChromeVox. My understanding is that the only purpose of these properties is to allow tabbing to the correct control when a screen reader's browse mode, scan mode, or equivalent is active, and the screen reader's cursor is not on a focusable control. In my opinion, that purpose is better served by the existing
SetSequentialFocusNavigationStartingPointaction, which will remain optional for toolkit developers.