fix: Prevent filtered node iterators from panicking when exhausted #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is quite critical as it hits a lot of Godot users on Linux. For reasons that are still unclear at this time, many systems have accessibility enabled with no apparent assistive technology running. Given this, I'm going to merge this and do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panics due to these calls to
Option::unwraphave been reported multiple times already, only by Godot users as far as I can tell. I am not sure exactly under which circumstances such panics can occur, the most likely cause is if the iterator is advanced after it has returnedNoneonce.