refactor!: Drop deprecated roles #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I forgot to tell you this on an earlier pull request: you need to include dummy changes to the Cargo.toml of accesskit_android, accesskit_unix and accesskit_winit so that these crates also get a minor version bump. This is because we're making breaking changes to the TreeUpdate API. Adding or removing empty lines at the end of the files is enough. |
DataTriny
changed the title
lukewarlow
force-pushed
the
remove-deprecated-roles
branch
from
d936b85 to
0d49515
Compare
Contributor
Author
|
Ah, makes sense. Done. |
Removes DescriptionListDetail, DescriptionListTerm, Directory, Portal, and Pre.
lukewarlow
force-pushed
the
remove-deprecated-roles
branch
from
0d49515 to
60383c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes DescriptionListDetail, DescriptionListTerm, Directory, Portal, and Pre.
These are all deprecated in Chromium so we can remove them from AccessKit.