Skip to content

Conversation

@bajrangCoder
Copy link
Collaborator

No description provided.

Copy link
Member

@UnschooledGamer UnschooledGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

@bajrangCoder
Copy link
Collaborator Author

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

In that cases there will some weird folding which will be obvious, what else we can do ?
Btw for now we will keep this solution in Acode(ace)

@UnschooledGamer
Copy link
Member

UnschooledGamer commented Nov 10, 2025

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

In that cases there will some weird folding which will be obvious, what else we can do ? Btw for now we will keep this solution in Acode(ace)

Could recalculate the folds based on the Updated Syntax Trees 🤔 💭

@bajrangCoder
Copy link
Collaborator Author

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

In that cases there will some weird folding which will be obvious, what else we can do ? Btw for now we will keep this solution in Acode(ace)

Could recalculate the folds based on the Updated Syntax Trees 🤔 💭

But how will it going to detect where it need the recalculation

@UnschooledGamer
Copy link
Member

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

In that cases there will some weird folding which will be obvious, what else we can do ? Btw for now we will keep this solution in Acode(ace)

Could recalculate the folds based on the Updated Syntax Trees 🤔 💭

But how will it going to detect where it need the recalculation

By viewing the coords of old folds & the type/level of folds, and recreating that fold.

@bajrangCoder
Copy link
Collaborator Author

The Implementation will work fine normally, But Incase where you had folded something like a method or a function, & the formatted code changes placement of them. This implementation may be problematic.

In that cases there will some weird folding which will be obvious, what else we can do ? Btw for now we will keep this solution in Acode(ace)

Could recalculate the folds based on the Updated Syntax Trees 🤔 💭

But how will it going to detect where it need the recalculation

By viewing the coords of old folds & the type/level of folds, and recreating that fold.

We can have some better solution in codemirror implementation

@UnschooledGamer
Copy link
Member

But how will it going to detect where it need the recalculation

By viewing the coords of old folds & the type/level of folds, and recreating that fold.

We can have some better solution in codemirror implementation

@bajrangCoder, you're right. Implement the same functionality in it. Also, whenever you touch it once again.
👍 for now

@UnschooledGamer UnschooledGamer merged commit 00adec3 into Acode-Foundation:main Nov 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants