Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 90 additions & 31 deletions lib/recursive-methods.rb
Original file line number Diff line number Diff line change
@@ -1,49 +1,108 @@
# Authoring recursive algorithms. Add comments including time and space complexity for each method.

# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n)
# Space complexity: also O(n), where a new method is stored n times in the call stack
def factorial(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented"
if n < 0
raise ArgumentError
end
if n <= 1
return 1
else
n * factorial(n - 1)
end
end

# Time complexity: ?
# Space complexity: ?
# Time complexity: The method is called n/2 times, and removing the constant we get O(n)
# Space complexity: Since the method creates a new array every time it is called and stores a method in the call stack, it takes up 2n memory, but removing the constant makes the space complexity O(n)
def reverse(s)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
This works, but because you create a new array with each recursive call this is O(n2) for both time/space complexity.

raise NotImplementedError, "Method not implemented"
if s.length > 1
first_char = s[0]
last_char = s[-1]
s = reverse(s.delete_prefix(s[0]).delete_suffix(s[-1]))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete_prefix & delete_suffix create new arrays and copy all the individual elements over and so this line is O(n) by itself.

return last_char + s + first_char
else
return s
end
end

# Time complexity: ?
# Space complexity: ?
def reverse_inplace(s)
raise NotImplementedError, "Method not implemented"
# Time complexity: O(n), similar to the reverse(s) method
# Space complexity: O(n), also similar to the reverse(s) method
def reverse_inplace(s, index = 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if index <= s.length/2
first_char = s[index-1]
last_char = s[-index]
s[index-1] = last_char
s[-index] = first_char
return reverse_inplace(s, index += 1)
else
return s
end
end

# Time complexity: ?
# Space complexity: ?
def bunny(n)
raise NotImplementedError, "Method not implemented"
# Time complexity: O(n)
# Space complexity: O(n), even though the method is storing a new "ears" value every time it is called
def bunny(n, ears = 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if ears == n + n
return ears
else
ears += 2
return bunny(n, ears)
end
end

# Time complexity: ?
# Space complexity: ?
def nested(s)
raise NotImplementedError, "Method not implemented"
# Time complexity: The method will be called n/2 (or n/2 + 1) times, but since we remove the constant it's O(n)
# Space complexity: O(n) (same reasoning as above)
def nested(s, i = 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if s.length % 2 != 0
return false
end
if i > s.length / 2 || s.length == 0
return true
elsif s[i-1] == "(" && s[-i] == ")"
return nested(s, i += 1)
else
return false
end
end

# Time complexity: ?
# Space complexity: ?
def search(array, value)
raise NotImplementedError, "Method not implemented"
# Time complexity: O(n), where n is the array length
# Space complexity: O(n), where n is the array length
def search(array, value, i = 0)
if array[i] == value
return true
elsif i > array.length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elsif i > array.length
elsif i >= array.length

return false
else
return search(array, value, i += 1)
end
end

# Time complexity: ?
# Space complexity: ?
def is_palindrome(s)
raise NotImplementedError, "Method not implemented"
# Time complexity: O(n), similar to the nested method
# Space complexity: O(n), same
def is_palindrome(s, i = 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if s[i-1] == s[-i] && i <= s.length/2
is_palindrome(s, i += 1)
elsif i > s.length/2
return true
else
return false
end
end

# Time complexity: ?
# Space complexity: ?
def digit_match(n, m)
raise NotImplementedError, "Method not implemented"
end
# Time complexity: O(n), where n is the number of digits in 'n' or 'm', whichever is smaller.
# Space complexity: O(n), same as above.
def digit_match(n, m, i = 0, result = 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

place = 10**i
if n == 0 && m == 0
return 1
end
if n - place >= 0 && m - place >= 0
if n/place % 10 == m/place % 10
result += 1
end
digit_match(n, m, i += 1, result)
else
return result
end
end