-
Notifications
You must be signed in to change notification settings - Fork 47
Sara-Branches #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sara-Branches #25
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,101 @@ | ||
| # Authoring recursive algorithms. Add comments including time and space complexity for each method. | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: 0(n) | ||
| # Space complexity: 0(n) | ||
| def factorial(n) | ||
| raise NotImplementedError, "Method not implemented" | ||
| raise ArgumentError if n < 0 | ||
| return 1 if n == 1 || n == 0 | ||
| return n * factorial(n-1) | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: 0(n) | ||
| # Space complexity: 0(n) | ||
| def reverse(s) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| raise NotImplementedError, "Method not implemented" | ||
|
|
||
| return s if s.length < 2 | ||
| return reverse(s[1..-1]) + s[0] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def reverse_inplace(s) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| raise NotImplementedError, "Method not implemented" | ||
| return s if s.length == 0 | ||
| return reverse(s[1..-1]) + s[0] | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def bunny(n) | ||
| raise NotImplementedError, "Method not implemented" | ||
| return 0 if n == 0 | ||
| return 2 if n == 1 | ||
| return bunny(n - 1) + bunny(1) | ||
|
|
||
| end | ||
|
|
||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
|
Comment on lines
37
to
38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ |
||
| def nested(s) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods. |
||
| raise NotImplementedError, "Method not implemented" | ||
| # return nested_helper(s[1..-1]) | ||
| paren_end = s.index(')') | ||
| return !s.include?('(') if paren_end.nil? | ||
|
|
||
| paren_start = s[0...paren_end].rindex('(') | ||
|
|
||
| return false if paren_start.nil? | ||
|
|
||
| return nested(s[1..paren_start]+s[paren_end+1..-1]) | ||
|
|
||
| end | ||
|
|
||
| def nested_helper(s) | ||
| return true if s.empty? | ||
| return false if s.length.odd? | ||
| return nested_helper(s) | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def search(array, value) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods. |
||
| raise NotImplementedError, "Method not implemented" | ||
| return false if array.nil? | ||
| return true if array[0] == value | ||
| return search(array[1..-1],value) | ||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def is_palindrome(s) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods. |
||
| raise NotImplementedError, "Method not implemented" | ||
| return true if s.empty? || s.length ==1 | ||
| return false if s[0] != s[s.length - 1] | ||
| return is_palindrome_helper(s, 1) | ||
|
|
||
| end | ||
|
|
||
| def is_palindrome_helper(s, index) | ||
| return true if s.empty? || s.length ==1 | ||
| return false if s[0] != s[s.length - index] | ||
| is_palindrome_helper(s[1..s.length - index - 1], 1) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're both slicing the array and using |
||
|
|
||
| end | ||
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| def digit_match(n, m) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| raise NotImplementedError, "Method not implemented" | ||
|
|
||
| return 1 if n == 0 && m == 0 | ||
| count = 0 | ||
| if n % 10 == m % 10 | ||
| count += 1 | ||
| end | ||
| if (n / 10 == 0 || m / 10 == 0) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🏆 Nice catch! |
||
| return count | ||
| end | ||
|
|
||
| return count + digit_match(n / 10, m / 10) | ||
|
|
||
| end | ||
|
|
||
| def digit_match_helper(n, m) | ||
|
|
||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍