Aimee 👾 - Fire 🔥 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 20, 2021
Comment on lines
+2
to
5
| // Time Complexity: O(n) - we iterate n times through nums, which is an array of length n | ||
| // Space Complexity: O(1) - we have constant space complexity, with variables max_result and temp_max | ||
|
|
||
| function maxSubArray(nums) { |
Comment on lines
+1
to
+5
| // Newman-Conway sequence: P(n) = P( P(n - 1)) + P(n - P(n - 1)), with intial conditions P(1)=1 and P(2)=1 | ||
| // Time Complexity: O(n) - there is a for loop in newmanConway that will run n number of times. The function p that it calls on has a time complexity of O(1) because it directly looks up the values in the array it's adding to. | ||
| // Space Complexity: O(n) - both the newmanConway and p functions add n elements to their data structures. | ||
|
|
||
| // Time Complexity: | ||
| // Space Complexity: | ||
| newmanConway = (num) => { |
There was a problem hiding this comment.
pValues, your recursion is making this O(3^n) .
Instead you should loop from 1 to num calculating the newmanConway value and storing it in your "memo." for lookup later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.