[Bug]: Invalid regex in Ada TextMate grammar

[slevithan]

Environment

• OS and Version: N/A
• IDE Version: N/A
• Ada & SPARK Extension Version: Latest

Bug Summary and Reproducer

Bug Summary:

This line is an invalid regex pattern ("(?=(;|\\))"), since it contains an unclosed group. It should include a third ) at the end, since the second-last closing paren is escaped and matches a literal ).

(Note that the correctly-closed version of this pattern ("(?=(;|\\)))") appears four other times in the same file. It is only this one instance that is missing the final closing paren.)

The result of this bug is that the pattern is an invalid Oniguruma regex, and it fails silently in vscode-textmate. It also causes the Ada grammar to error when using Shiki's JavaScript engine, since by default its JS engine doesn't silence regex errors.

Configuration and Logs

N/A

Other VS Code Extensions

No response

Additional context

No response

[eliericha]

Hello @slevithan ,

Thank you for reporting this issue and submitting a fix. I'm not sure we will be able to authorize the change right now because most of the team is away for the end of year holidays and my account doesn't have authorization to validate PRs.

But I'll ping some people and see what can be done :)

Note that this syntax file integration/vscode/ada/advanced/ada.tmLanguage.json is not the one used by the VS Code extension. It is the simpler version in integration/vscode/ada/syntaxes/ada.tmLanguage.json which is used.

[slevithan]

It would of course be great to get this fix landed sooner than later, so thank you for checking!

And thanks for the pointer. I just checked, and integration/vscode/ada/syntaxes/ada.tmLanguage.json doesn't include the same bug. But Shiki uses the advanced/ version.

[reznikmm]

thanks for the fix