Fix backward incompatible change of VPC endpoint names #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierretr
changed the title
The commit 2094dfc introduced a backward incompatible change as VPC endpoints names cannot be changed easily when redeploying a stack. Redeployment failed with the following kind of errors: "private-dns-enabled cannot be set because there is already a conflicting DNS domain for email-smtp.eu-west-1.amazonaws.com" This change reverts default VPC endpoint names and add an option to prefix them by the name of the VPC.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 83.70% 83.72% +0.02%
==========================================
Files 47 47
Lines 3841 3847 +6
==========================================
+ Hits 3215 3221 +6
Misses 626 626
☔ View full report in Codecov by Sentry. |
RomaricKanyamibwa
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 2094dfc introduced a backward incompatible change as VPC endpoints names cannot be changed easily when redeploying a stack. Redeployment failed with the following kind of errors:
"private-dns-enabled cannot be set because there is already a conflicting DNS domain for email-smtp.eu-west-1.amazonaws.com"
This change reverts default VPC endpoint names and add an option to prefix them by the name of the VPC.