Better formatting for editing, grammar changes and change to adding interoperability #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in some grammar corrections and clarifications
martintc
changed the title
|
Hi there! Thank you for you help, but this docs repository is auto generated from main AdaEngine/AdaEngine repository. If you want to fix the grammar issues, pls commit to https://github.com/AdaEngine/AdaEngine/tree/main/Sources/AdaEngine/AdaEngine.docc directory. I will note this in README for the future. Sorry for that! |
|
Its not problem at all. I'll take a look at the docs where you point to and make a PR for the corrections there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in some grammar corrections and clarifications.
One major change to the instructions.
There is mention to
Add -enable-experimental-cxx-interop value to your OTHER_SWIFT_FLAGS.However this was failing to build for me. I changed the compilation flag to-cxx-interoperability-mode=defaultthat I found from here