Skip to content

Adds open URL handler to AdaWebHost for Universal Link support #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds open URL handler to AdaWebHost for Universal Link support #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3de379
Adds open URL handler
mharper Mar 21, 2023
2d01432
Merge pull request #1 from mharper/task/mharper/add-open-url-handler
mharper Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions EmbedFramework/AdaWebHost.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ public class AdaWebHost: NSObject {
/// If commands are sent prior to `embedReady`, store until it can be cleared out
private var pendingCommands = [String]()

/// URL handler
private var openUrlHandler: ((URL) -> Bool)?

public init(
handle: String,
cluster: String = "",
Expand All @@ -105,7 +108,8 @@ public class AdaWebHost: NSObject {
eventCallbacks: [String: (_ event: [String: Any]) -> Void]? = nil,
webViewTimeout: Double = 30.0,
deviceToken: String = "",
navigationBarOpaqueBackground: Bool = false
navigationBarOpaqueBackground: Bool = false,
openUrlHandler: ((URL) -> Bool)? = nil
) {
self.handle = handle
self.cluster = cluster
Expand All @@ -127,7 +131,8 @@ public class AdaWebHost: NSObject {
self.hasError = false
self.deviceToken = deviceToken
self.navigationBarOpaqueBackground = navigationBarOpaqueBackground

self.openUrlHandler = openUrlHandler

self.reachability = Reachability()!
super.init()

Expand Down Expand Up @@ -434,6 +439,13 @@ extension AdaWebHost: WKNavigationDelegate, WKUIDelegate, WKDownloadDelegate {

// Shared function to handle opening of urls
public func openUrl(webView: WKWebView, url: URL) -> Swift.Void {
// If there's a handler for opening the URL and it returns `true`, then
// skip the rest of the URL handling logic here.
if let openUrlHandler,
openUrlHandler(url) {
return
}

let httpSchemes = ["http", "https"]
let urlScheme = url.scheme
// Handle opening universal links within the host App
Expand Down