Skip to content

Feature/add delegate methods #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 12, 2022
Merged

Feature/add delegate methods #10

merged 12 commits into from
Feb 12, 2022

Conversation

@martiliones
Copy link
Collaborator

@martiliones martiliones commented Feb 9, 2022

No description provided.

adamant-al
adamant-al reviewed Feb 10, 2022
View reviewed changes
adamant-al
adamant-al reviewed Feb 10, 2022
View reviewed changes
adamant-al
adamant-al reviewed Feb 10, 2022
View reviewed changes
adamant-al
adamant-al reviewed Feb 10, 2022
View reviewed changes
adamant-al
adamant-al reviewed Feb 10, 2022
View reviewed changes
adamant-al
adamant-al reviewed Feb 11, 2022
View reviewed changes
@adamant-al
Copy link
Member

adamant-al commented Feb 11, 2022

Update dependencies:
axios ^0.23.0 → ^0.25.0
bignumber.js ^9.0.1 → ^9.0.2
bitcore-mnemonic ^8.25.10 → ^8.25.25
ethereumjs-util ^7.1.3 → ^7.1.4

Leave these as is for now:
bitcoinjs-lib ^5.2.0 → ^6.0.1
socket.io-client ^2.4.0 → ^4.4.1

@martiliones martiliones added the enhancement New feature or request label Feb 12, 2022
gost1k337
gost1k337 suggested changes Feb 12, 2022
View reviewed changes
zasulskii
zasulskii reviewed Feb 12, 2022
View reviewed changes
zasulskii
zasulskii reviewed Feb 12, 2022
View reviewed changes
@adamant-al
Copy link
Member

adamant-al commented Feb 12, 2022

Should we add linter and tests here?

@martiliones
Copy link
Collaborator Author

martiliones commented Feb 12, 2022

Should we add linter and tests here?

In fact, I just found a bug so it is preferable to write tests. Linter should be added for the whole project, now eslint returns 800+ problems

@adamant-al
Copy link
Member

adamant-al commented Feb 12, 2022 •
edited
Loading

In fact, I just found a bug so it is preferable to write tests. Linter should be added for the whole project, now eslint returns 800+ problems

So do it :)
For new projects/repos, we better discuss the standard/rules. Current projects use different rules. Not sure, is it good or bad.

@martiliones martiliones merged commit 936e7cd into master Feb 12, 2022
@martiliones martiliones deleted the feature/add-delegate branch February 12, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamant-al adamant-al adamant-al approved these changes

+2 more reviewers

@gost1k337 gost1k337 gost1k337 approved these changes

@zasulskii zasulskii zasulskii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@martiliones @adamant-al @gost1k337 @zasulskii