fix: align release tests with computed build version#51
Merged
Conversation
Use GH_ATTACH_BUILD_VERSION as the expected version for release-built binaries during test runs, while preserving the package.json expectation for unbuilt checkout execution paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- let version-sensitive binary tests honor GH_ATTACH_BUILD_VERSION when set\n- keep the unbuilt local-checkout gh extension path asserting package.json version\n- pass GH_ATTACH_BUILD_VERSION into the release job's npm test step\n\n## Validation\n- npm run lint\n- npm run format:check\n- npm run typecheck\n- GH_ATTACH_BUILD_VERSION=9.9.9 npm run build\n- GH_ATTACH_BUILD_VERSION=9.9.9 GH_ATTACH_PKG_TARGETS=node18-macos-arm64 npm run package\n- GH_ATTACH_BUILD_VERSION=9.9.9 npm test\n- ./bin/gh-attach-darwin-arm64 --version