Skip to content

Conversation

@lancergr
Copy link
Contributor

Description
Use API key if provided
Added PaymentsRequest constants and helpers

Tested scenarios
Payments and Modifications

@lancergr lancergr self-assigned this Aug 28, 2018
@coveralls
Copy link

coveralls commented Aug 28, 2018

Coverage Status

Coverage decreased (-0.1%) to 27.075% when pulling 7537f42 on apikey into da99e9d on develop.

try {
date = monthYear.parse(expiryDate);
} catch (ParseException e) {
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add log statement in catch before returning null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can skip return statement in catch and replace it like :
Date date;
SimpleDateFormat monthYear = new SimpleDateFormat("M/yyyy");
try {
date = monthYear.parse(expiryDate);
} catch (ParseException e) {
//log statment here
}
return date;
}

@lancergr lancergr merged commit 8be004d into develop Sep 3, 2018
@lancergr lancergr deleted the apikey branch September 3, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants