Skip to content

Add store to payment request #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2018
Merged

Add store to payment request #123

merged 2 commits into from
Oct 3, 2018

Conversation

@sundbarg
Copy link
Contributor

@sundbarg sundbarg commented Oct 3, 2018

No description provided.

@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 27.063% when pulling 1d72617 on daforsman:store-to-payment-request into f159322 on Adyen:develop.

lancergr
lancergr reviewed Oct 3, 2018
View reviewed changes
src/main/java/com/adyen/model/PaymentRequest.java Outdated
private BankAccount bankAccount = null;

@SerializedName("store")
private Long store = null;
Copy link
Contributor

@lancergr lancergr Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please change the type to String since it is defined as such:
https://github.com/Adyen/adyen-openapi/blob/master/specs/3.0/PaymentService-V30.yaml#L813

Copy link
Contributor Author

@sundbarg sundbarg Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that, I changed 👍

@sundbarg
Copy link
Contributor Author

sundbarg commented Oct 3, 2018

Thanks! I dont have merge access, so someone else will have to merge

@rkewlani
Copy link
Contributor

rkewlani commented Oct 3, 2018

Thanks! I dont have merge access, so someone else will have to merge

Thanks for your contribution. I am merging it.

@rkewlani rkewlani merged commit 63e694d into Adyen:develop Oct 3, 2018
@sundbarg sundbarg deleted the store-to-payment-request branch October 3, 2018 14:10
@sundbarg
Copy link
Contributor Author

sundbarg commented Oct 10, 2018

@rkewlani @lancergr is this only available on test right now? Will a payment request fail if I add this field on prod requests?

@rkewlani
Copy link
Contributor

rkewlani commented Oct 11, 2018 •
edited
Loading

Hi @daforsman,
Your change is available in 1.5.4 release. Are you seeing any issues ? What error you are getting ?

Thanks,
Rajni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleffio Aleffio Awaiting requested review from Aleffio

@rikterbeek rikterbeek Awaiting requested review from rikterbeek

@maassenbas maassenbas Awaiting requested review from maassenbas

2 more reviewers

@lancergr lancergr lancergr approved these changes

@rkewlani rkewlani rkewlani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sundbarg @coveralls @rkewlani @lancergr