Add helper to set raw card data #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikterbeek
requested review from
Aleffio,
cyattilakiss,
lancergr,
maassenbas and
rkewlani
cyattilakiss
approved these changes
Oct 19, 2018
Aleffio
reviewed
Oct 19, 2018
| paymentsRequest.putPaymentMethodItem("expiryYear", "2018"); | ||
| paymentsRequest.putPaymentMethodItem("holderName", "John Smith"); | ||
| paymentsRequest.putPaymentMethodItem("cvc", "737"); | ||
| paymentsRequest.addCardData("4111111111111111", "expiryMonth", "2018", "737", "John Smith"); |
Contributor
There was a problem hiding this comment.
"expiryMonth" should be "08" instead?
should we also update to "10", "2020"?
Contributor
Author
There was a problem hiding this comment.
Hi @Aleffio , yes of course, will change it.
|
Thanks for ur help.
发自我的 iPhone
… 在 2018年10月19日，下午3:56，Alessio Zampatti ***@***.***> 写道：
@Aleffio commented on this pull request.
In src/test/java/com/adyen/CheckoutTest.java:
> @@ -219,15 +219,7 @@ protected PaymentsRequest createPaymentsCheckoutRequest() {
paymentsRequest.setReference("Your order number");
paymentsRequest.setAmount(createAmountObject("USD", 1000L));
- PaymentMethod paymentMethod = new PaymentMethod();
- paymentMethod.setType("scheme");
- paymentsRequest.setPaymentMethod(new HashMap<String, String>());
-
- paymentsRequest.putPaymentMethodItem("number", "4111111111111111");
- paymentsRequest.putPaymentMethodItem("expiryMonth", "08");
- paymentsRequest.putPaymentMethodItem("expiryYear", "2018");
- paymentsRequest.putPaymentMethodItem("holderName", "John Smith");
- paymentsRequest.putPaymentMethodItem("cvc", "737");
+ paymentsRequest.addCardData("4111111111111111", "expiryMonth", "2018", "737", "John Smith");
"expiryMonth" should be "08" instead?
should we also update to "10", "2020"?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add helper to easily provide card data as well added a new constructor to set required fields for better sample code and easier integration.
Tested scenarios
Fixed issue: