Added paymentMethod DTO for /payments call #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkewlani
reviewed
Oct 30, 2018
| this.paymentMethod.put(RECURRING_DETAIL_REFERENCE, recurringDetailReference); | ||
| this.paymentMethod.put(ENCRYPTED_SECURITY_CODE, encryptedSecurityCode); | ||
| DefaultPaymentMethodDetails paymentMethodDetails = new DefaultPaymentMethodDetails(); | ||
| this.paymentMethod = paymentMethodDetails; |
Contributor
There was a problem hiding this comment.
minor: exchange of 634 and 636 will make it more readable.
rkewlani
reviewed
Oct 30, 2018
| this.paymentMethod.put(ENCRYPTED_EXPIRY_MONTH, encryptedExpiryMonth); | ||
| this.paymentMethod.put(ENCRYPTED_EXPIRY_YEAR, encryptedExpiryYear); | ||
| DefaultPaymentMethodDetails paymentMethodDetails = new DefaultPaymentMethodDetails(); | ||
| this.paymentMethod = paymentMethodDetails; |
Contributor
There was a problem hiding this comment.
minor: moving L598 to 608 will make it more readable.
rkewlani
reviewed
Oct 30, 2018
lancergr
force-pushed
the
checkout-paymentMethod
branch
from
3206a51 to
45e667f
Compare
rkewlani
approved these changes
Oct 31, 2018
Aleffio
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added paymentMethod DTO for /payments call
Tested scenarios
/payments with CC and APM