Custom read timeout for HttpURLConnection #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @marinan87 so much for opening a Pull Request for that! I believe removing client constructors is good idea for keeping simplicity. Could you please revert the removed client constructors and mark them as deprecated so that the backwards compatibility is maintained and we can remove them in a new major version? Best Regards, |
…ility; mark them as deprecated
Author
|
Hi @lancergr, I did the changes you requested. 4 constructors are restored and marked as @deprecated. Please review. Best regards, |
lancergr
approved these changes
Nov 12, 2018
Contributor
lancergr
left a comment
lancergr
left a comment
There was a problem hiding this comment.
Thanks @marinan87 - it looks fine!
rkewlani
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See Adyen Support ticket #447790
Tested scenarios
Tested locally simulating network outage after establishing initial connection.
Fixed issue: