Pw 666 checkout payment v40 and Application info #148

AlexandrosMor · 2018-12-17T13:08:27Z

No description provided.

coveralls · 2018-12-17T13:13:00Z

Coverage decreased (-1.9%) to 24.849% when pulling b8c49b5 on PW-666-CheckoutPaymentV40 into 743a0b7 on develop.

rkewlani · 2018-12-17T14:00:18Z

.idea.bak/compiler.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>


Can you please remove all .idea/* files ?

yes the files are removed

Aleffio · 2018-12-17T14:08:26Z

src/main/java/com/adyen/model/BrowserInfo.java

- * Copyright (c) 2017 Adyen B.V.
- * This file is open source and available under the MIT license.
- * See the LICENSE file for more info.
- */


please readd copyright

src/main/java/com/adyen/model/DeviceRenderOptions.java

Aleffio · 2018-12-17T14:15:21Z

src/main/java/com/adyen/model/PaymentRequest3d.java

- *                                      ######
- *                               #############
- *                               ############
- *


please fix copyright

src/main/java/com/adyen/model/PaymentRequest3ds2.java

Aleffio · 2018-12-17T14:21:11Z

src/main/java/com/adyen/model/checkout/PaymentResultResponse.java

    @Override
    public int hashCode() {
-        return Objects.hash(additionalData, authResponse, errorMessage, fraudResult, merchantReference, pspReference, refusalReason, resultCode);
+        return Objects.hash(additionalData, authResponse, fraudResult, merchantReference, pspReference, refusalReason, resultCode);


please add refusalReasonCode

Aleffio · 2018-12-17T14:27:07Z

src/main/java/com/adyen/model/checkout/PaymentSessionRequest.java

-                && Objects.equals(this.socialSecurityNumber, paymentSessionRequest.socialSecurityNumber)
-                && Objects.equals(this.telephoneNumber, paymentSessionRequest.telephoneNumber)
-                && Objects.equals(this.token, paymentSessionRequest.token);
+        PaymentSessionRequest paymentSetupRequest = (PaymentSessionRequest) o;


should this be called paymentSessionRequest?

Aleffio · 2018-12-17T14:27:20Z

src/main/java/com/adyen/model/checkout/PaymentSessionRequest.java

    public String toString() {
        StringBuilder sb = new StringBuilder();
-        sb.append("class PaymentSessionRequest {\n");
+        sb.append("class PaymentSetupRequest {\n");


same as above

Aleffio · 2018-12-17T14:37:33Z

src/main/java/com/adyen/service/Modification.java

+    public ModificationResult adjustAuthorization(AdjustAuthorisationRequest adjustAuthorisationRequest, RequestOptions requestOptions) throws IOException, ApiException {
+
+        String jsonRequest = serializeRequest(adjustAuthorisationRequest);
+        String jsonResult = cancel.request(jsonRequest, requestOptions);


is this calling the cancel endpoint?

Aleffio · 2018-12-17T14:37:50Z

src/main/java/com/adyen/service/Modification.java

+    public ModificationResult technicalCancel(TechnicalCancelRequest technicalCancelRequest, RequestOptions requestOptions) throws IOException, ApiException {
+
+        String jsonRequest = serializeRequest(technicalCancelRequest);
+        String jsonResult = cancel.request(jsonRequest, requestOptions);


is this calling the cancel endpoint?

Aleffio · 2018-12-17T15:03:32Z

src/main/java/com/adyen/service/resource/payment/Authorise3DS2.java

+import com.adyen.Service;
+import com.adyen.service.Resource;
+
+public class Authorise3DS2 extends Resource {


is this used?

Based the documentation it is used
https://docs.adyen.com/api-explorer/#/Payment/v40/authorise3ds2

rikterbeek · 2018-12-18T13:03:04Z

@AlexandrosMor please remove all autogenerated code starting with @javax.annotation.Generated

rkewlani · 2018-12-18T13:06:18Z

src/main/java/com/adyen/model/SDKEphemPubKey.java

+/**
+ * SDKEphemPubKey
+ */
+@javax.annotation.Generated(value = "io.swagger.codegen.languages.java.JavaClientCodegen", date = "2018-12-06T14:10:59.920Z[GMT]")


Please remove swagger autogenerated annotations.

rkewlani · 2018-12-18T13:10:48Z

src/main/java/com/adyen/model/checkout/ModelConfiguration.java

-/**
- * ModelConfiguration
- */
+@javax.annotation.Generated(value = "io.swagger.codegen.languages.java.JavaClientCodegen", date = "2018-12-11T13:51:52.335Z[GMT]")


same as above, remove swagger annotation

rkewlani · 2018-12-18T13:11:44Z

src/main/java/com/adyen/model/checkout/PaymentMethodsRequest.java

+    @SerializedName("accountInfo")
+    private AccountInfo accountInfo = null;
+
+    @SerializedName("applciationInfo")


ApplicationInfo is not applicable for PaymentMethodRequest

Checking the PaymentSetupAndVerificationService-v40.json the applicationInfo it is in the properties.

rkewlani · 2018-12-18T13:16:25Z

src/main/java/com/adyen/model/checkout/ShopperInput.java

+/**
+ * ShopperInput
+ */
+@javax.annotation.Generated(value = "io.swagger.codegen.languages.java.JavaClientCodegen", date = "2018-11-08T13:12:01.900Z[GMT]")


Same as above, please remove swagger annotation.

AlexandrosMor added 8 commits December 6, 2018 20:27

models for paymentService and CheckoutService

16ed51d

Optimise imports

9934c6b

Checkout v40

3e0a378

Fix the checkstyle issues

aef91a9

fix tests

e810988

Finalize models

c53473c

Add technicalCancel and adjustAuthorisation endpoints

4cf52e1

add application info

27cf598

AlexandrosMor requested review from Aleffio, cyattilakiss, maassenbas, rikterbeek and rkewlani December 17, 2018 13:08

rkewlani reviewed Dec 17, 2018

View reviewed changes

remove idea/* files

65ce928

Aleffio reviewed Dec 17, 2018

View reviewed changes

AlexandrosMor added 3 commits December 17, 2018 17:34

Fix copyright on files, payment and modification

c67cb83

Remove unused import, format lines

0acc170

add missing javadoc

98ab237

rkewlani reviewed Dec 18, 2018

View reviewed changes

AlexandrosMor added 2 commits December 18, 2018 21:50

Remove swagger anotations

3e15df2

add endpoints authorise3ds retrieve3ds2Result

b8c49b5

rikterbeek approved these changes Dec 24, 2018

View reviewed changes

AlexandrosMor merged commit 347bdde into develop Dec 24, 2018

rkewlani deleted the PW-666-CheckoutPaymentV40 branch September 24, 2020 19:10

Pw 666 checkout payment v40 and Application info #148

Pw 666 checkout payment v40 and Application info #148

Uh oh!

Conversation

AlexandrosMor commented Dec 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Dec 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rikterbeek commented Dec 18, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexandrosMor Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AlexandrosMor commented Dec 17, 2018 •

edited

Loading

coveralls commented Dec 17, 2018 •

edited

Loading

AlexandrosMor Dec 18, 2018 •

edited

Loading