Skip to content

Renamed "idealIssuer" to "issuer" on DefaultPaymentMethodDetails #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2019
Merged

Renamed "idealIssuer" to "issuer" on DefaultPaymentMethodDetails #261

merged 2 commits into from
Nov 1, 2019

Conversation

martinsrenato
Copy link
Contributor

Fixed issue: #255

@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.007%) to 23.798% when pulling d78e55f on gh-255-issuer into 7f19b44 on develop.

rikterbeek
rikterbeek suggested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@rikterbeek rikterbeek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break backwards compatibility. I would just add the issuer beside the idealIssuer. and mark idealIssuer as deprecate.

@rkewlani rkewlani merged commit 20d04ef into develop Nov 1, 2019
@martinsrenato martinsrenato deleted the gh-255-issuer branch December 10, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkewlani rkewlani Awaiting requested review from rkewlani

@AlexandrosMor AlexandrosMor Awaiting requested review from AlexandrosMor

1 more reviewer

@rikterbeek rikterbeek rikterbeek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martinsrenato @coveralls @rikterbeek @rkewlani