[PW-7442] Change JSON.java template to fix byte-array adapter #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
requested review from
AlexandrosMor,
Morerice,
michaelpaul and
wboereboom
as code owners
jillingk
changed the title
wboereboom
reviewed
Dec 23, 2022
|
|
||
| String expected = "\"mpiData\":{\"cavv\":\"AQIDBAUGBwgJCgsMDQ4PEBESExQ=\"}"; | ||
| // Unicode representation of the string | ||
| String expected = "\"mpiData\":{\"cavv\":\"AQIDBAUGBwgJCgsMDQ4PEBESExQ\\u003d\"}"; |
There was a problem hiding this comment.
Does the API expect this format?
There was a problem hiding this comment.
This is unicode, which apparently most APIs would be able to handle just fine. @michaelpaul do you think our API's handle this? I can alternatively remove this by ignoring the html escaping in the gsonbuilder.
There was a problem hiding this comment.
Just verified with actual request in api logs, API does properly parse this string with the html escaping like that!
There was a problem hiding this comment.
Here it's our previous encoder:
I think we can proceed with this new one since its very similar.
michaelpaul
approved these changes
Dec 23, 2022
wboereboom
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed base64 encoding from bytearray adapter, and generated the JSON.java classes again.
Tested scenarios
UT's