Skip to content

Conversation

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Sep 17, 2025

Parsing failed if you had multiple union distinct or except. This PR fixes it by doing the same thing as union all

unionAllExpr, err := p.parseSelectQuery(p.Pos())

Added tests that are failing without this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17813370117

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 50.072%

Totals Coverage Status
Change from base Build 17784400776: 0.02%
Covered Lines: 7293
Relevant Lines: 14565

💛 - Coveralls

@git-hulk git-hulk merged commit 752d6e7 into AfterShip:master Sep 18, 2025
2 checks passed
@git-hulk
Copy link
Member

@erezrokah Thanks for your fix.

@erezrokah erezrokah deleted the fix/multi_distinct_except branch September 18, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants