Skip to content

Conversation

@ajruckman
Copy link
Contributor

Updates parseLiteral() to handle identifiers like Float32 (previously only handled literals) and return *Ident directly. Remove unnecessary parseTypeParameter() wrapper; parseLiteral just needed a new case to handle TokenKindIdent which is now possible.

This allows us to add QBit case to the column type parser to support it in ClickHouse 25.10: https://clickhouse.com/docs/sql-reference/data-types/qbit

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18885628675

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 50.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_common.go 2 3 66.67%
Totals Coverage Status
Change from base Build 18873747432: 0.01%
Covered Lines: 7513
Relevant Lines: 14950

💛 - Coveralls

@git-hulk
Copy link
Member

@ajruckman Thank you for your contributions.

@git-hulk git-hulk merged commit 0b8b2e3 into AfterShip:master Oct 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants