Skip to content

Conversation

@snuyanzin
Copy link
Contributor

About this change - What it does

The PR adds

  1. Fix the command to launch sql client: ./sql-cli.sh => sql-client.sh
  2. Add one liner to start sql-client:
docker exec -it $(docker ps -qlf name=sql-cli-for-apache-flink-docker_sql-client) /opt/sql-client/sql-client.sh

Why this way

  1. There is no ./sql-cli.sh => such command fails
  2. One line instead of several could minimize amount of manual work and could be easily copy-pasted from README.md

The PR adds 
1. Fix the command to launch sql client: ./sql-cli.sh => sql-client.sh
2. Add one liner to start sql-client:
```
docker exec -it $(docker ps -qlf name=sql-cli-for-apache-flink-docker_sql-client) /opt/sql-client/sql-client.sh

```
Copy link
Collaborator

@ftisiot ftisiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@ftisiot ftisiot merged commit a799082 into Aiven-Open:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants