Coding ground/merge #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlightBooking Test Updates
HotelBookinngPage, HotelBookingTest
TestNG Suite XML Listeners AddAnnotations SignInPage, SignInTest, FlightBookingPage updates uitestconfig extra field added
Screenshot pom dependency added testNG xml edit listener added FlightBookingTest update HotelBookingTest update SignInTest update
failures. But manual input of date is more preferred which was the case is previous push.
Removing Ui common methods that use switch with string condition since compilation compatability changes should be made Renaming ModelTypeUi class to UiConstants Adding review comments txt file blank for now
Coding round/child
UiCommon Coommenting switchcase with string condition due to jre compliance issue Dummy.java adding comments
Merge before master pill request final
Coding round/child clone To Master Branch Copy CodingRound/merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final merge request with all the changes to master branch