Fix CREATE INDEX to support qualified table names #2185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CREATE INDEX failed with
TypeError: undefined is not an object (evaluating 'table.inddefs')when using qualified table names (e.g.,database.table). The parser already supported qualified names, but the execute function did not resolve the database correctly.Changes
Modified
src/65createindex.js:this.table.databaseid || databaseid(line 23)Added
test/test2184.js:Example
Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
upload.wikimedia.org/usr/local/bin/node node_modules/mocha/bin/mocha.js ./test --reporter dot --bail test/test2184.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.