-
Notifications
You must be signed in to change notification settings - Fork 690
Fix SHOW COLUMNS and SHOW INDEX to resolve qualified table names #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mathiasrw
merged 5 commits into
develop
from
copilot/fix-qualified-table-name-resolution
Nov 20, 2025
Merged
Fix SHOW COLUMNS and SHOW INDEX to resolve qualified table names #2201
mathiasrw
merged 5 commits into
develop
from
copilot/fix-qualified-table-name-resolution
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix qualified table name resolution in SHOW COLUMNS and SHOW INDEX
Fix SHOW COLUMNS and SHOW INDEX to resolve qualified table names
Nov 19, 2025
Copilot finished work on behalf of
mathiasrw
November 19, 2025 22:46
mathiasrw
requested changes
Nov 19, 2025
Member
|
@copilot Please see the comments. |
…le to testId Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
mathiasrw
November 19, 2025 23:11
mathiasrw
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOW COLUMNSandSHOW INDEXcommands fail when using qualified table names (e.g.,database.table), returning empty arrays instead of metadata. Works with unqualified names usingUSEcontext.Changes
src/78show.js
ShowColumns.prototype.execute()andShowIndex.prototype.execute()to checkthis.table.databaseidbefore falling back tothis.databaseidor defaultdatabaseidTablerule, but execution code only checked legacyFROM table FROM databasesyntaxtest/test2200.js
before()andafter()hooks for setup and cleanuptestIdvariable namingExample
Original prompt
<issue_description> SHOW COLUMNS and SHOW INDEX don't resolve qualified table names.
in test613.js i tried to use qualitfied table names, but it returns empty array [] instead of column/index metadata.
Works with unqualified names + USE context, fails with qualified names.
Root cause: Metadata commands don't parse qualified names correctly.
Needs parser/executor updates similar to how SELECT handles qualified names.
</issue_description>
<agent_instructions>Start by making a test2200.js test file that demonstrates the behavour.
Then change the src files to make it work. I expect that you will have to edit the grammar/parser. Please aims for small precise changes to the alasqlparser.jison file and after do
yarn jison && yarn testto confirm.Always run
yarn format-allbefore making a commit. </agent_instructions>Comments on the Issue (you are @copilot in this section)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.