Fix REPLACE function to handle numbers like MySQL/SQLite

src/55functions.js

@@ -454,7 +454,9 @@ Object.keys(alasql._aggrOriginal).forEach(function (k) {
 
 // String functions
 stdfn.REPLACE = function (target, pattern, replacement) {
-	return (target.toString() || '').split(pattern).join(replacement);
+	return (target == null ? '' : target.toString())
+		.split(pattern == null ? '' : pattern.toString())
+		.join(replacement == null ? '' : replacement.toString());
 };
 
 // This array is required for fast GUID generation

test/test1455.js

@@ -3,49 +3,36 @@ if (typeof exports === 'object') {
 	var alasql = require('..');
 }
 
-describe('Test 000 - multiple statements', function () {
-	const test = '000'; // insert test file number
+describe('Test 1455 - REPLACE function', function () {
+	it('A) REPLACE with string target', function () {
+		var res = alasql("SELECT REPLACE('123', '2', '_') AS result");
+		assert.deepEqual(res, [{result: '1_3'}]);
+	});
 
-	before(function () {
-		alasql('create database test' + test);
-		alasql('use test' + test);
+	it('B) REPLACE with number target', function () {
+		var res = alasql("SELECT REPLACE(123, '2', '_') AS result");
+		assert.deepEqual(res, [{result: '1_3'}]);
 	});
 
-	after(function () {
-		alasql('drop database test' + test);
+	it('C) REPLACE with string and number returning same result', function () {
+		var res = alasql(
+			"SELECT REPLACE('123', '2', '_') AS str_result, REPLACE(123, '2', '_') AS num_result"
+		);
+		assert.deepEqual(res, [{str_result: '1_3', num_result: '1_3'}]);
 	});
 
-	it('A) From single lines', function () {
-		var res = [];
-		res.push(alasql('create table one (a int)'));
-		res.push(alasql('insert into one values (1),(2),(3),(4),(5)'));
-		res.push(alasql('select * from one'));
-		assert.deepEqual(res, [1, 5, [{a: 1}, {a: 2}, {a: 3}, {a: 4}, {a: 5}]]);
+	it('D) REPLACE with number in pattern', function () {
+		var res = alasql("SELECT REPLACE('123', 2, '_') AS result");
+		assert.deepEqual(res, [{result: '1_3'}]);
 	});
 
-	it('B) Multiple statements in one string', function () {
-		//
-		var sql = 'create table two (a int);';
-		sql += 'insert into two values (1),(2),(3),(4),(5);';
-		sql += 'select * from two;';
-		var res = alasql(sql);
-		assert.deepEqual(res, [1, 5, [{a: 1}, {a: 2}, {a: 3}, {a: 4}, {a: 5}]]);
+	it('E) REPLACE with number in replacement', function () {
+		var res = alasql("SELECT REPLACE('1_3', '_', 2) AS result");
+		assert.deepEqual(res, [{result: '123'}]);
 	});
 
-	it('C) Multiple statements in one string with callback', function (done) {
-		// Please note that first parameter (here `done`) must be called if defined - and is needed when testing async code
-		var sql = 'create table three (a int);';
-		sql += 'insert into three values (1),(2),(3),(4),(5);';
-		sql += 'select * from three;';
-		alasql(sql, function (res) {
-			assert.deepEqual(res, [1, 5, [{a: 1}, {a: 2}, {a: 3}, {a: 4}, {a: 5}]]);
-			done();
-		});
+	it('F) REPLACE with all numbers', function () {
+		var res = alasql('SELECT REPLACE(123, 2, 9) AS result');
+		assert.deepEqual(res, [{result: '193'}]);
 	});
 });
-stdfn.REPLACE = function (target, pattern, replacement) {
-    if (typeof target !== 'string') {
-        throw new TypeError('Target must be a string');
-    }
-    return target.split(pattern).join(replacement);
-};