Conversation
DanySK
force-pushed
the
refactor/sapere/extractmatchcreationandf
branch
from
c729988 to
7da572c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the SAPERE LsaNeighborhoodCondition to split the match-creation and match-filtering logic into dedicated helper methods, improving readability and separation of concerns inside the condition evaluation pipeline.
Changes:
- Extracted initial match creation into
createInitialMatches(...). - Extracted filtering of existing matches into
filterExistingMatches(...). - Further split existing-match filtering into selected-node vs non-selected-node branches.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
=========================================
Coverage 61.53% 61.53%
Complexity 14 14
=========================================
Files 2 2
Lines 78 78
Branches 4 4
=========================================
Hits 48 48
Misses 24 24
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DanySK
force-pushed
the
refactor/sapere/extractmatchcreationandf
branch
10 times, most recently
from
6839fdc to
75b4b91
Compare
…model/sapere/conditions/LsaNeighborhoodCondition.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DanySK
force-pushed
the
refactor/sapere/extractmatchcreationandf
branch
from
75b4b91 to
10dd3ce
Compare
|
DanySK
pushed a commit
that referenced
this pull request
Apr 30, 2026
## [43.0.45](43.0.44...43.0.45) (2026-04-30) ### Dependency updates * **deps:** update dependency org.danilopianini.gradle-kotlin-qa:org.danilopianini.gradle-kotlin-qa.gradle.plugin to v1.6.1 ([#5323](#5323)) ([249a798](249a798)) ### Bug Fixes * **incarnation-sapere:** validate chemotaxis argument explicitly ([#5326](#5326)) ([93a9f5b](93a9f5b)) ### Tests * **cognitive-agents:** replace unsafe map assertions in steering tests ([#5327](#5327)) ([d4c43d4](d4c43d4)) ### General maintenance * **build:** update the javadoc.io cache ([d2571fd](d2571fd)) ### Refactoring * **sapere:** extract match creation and filtering logic into separate methods ([#5318](#5318)) ([eec1c07](eec1c07)) * **sapere:** simplify execution logic in SAPEREReaction ([#5317](#5317)) ([0b71e90](0b71e90))
Member
Author
|
🎉 This PR is included in version 43.0.45 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.