feat: refactor Search API with concurrent batch support and multi-collection capability#16
Merged
Conversation
alphamt
requested changes
Dec 4, 2025
alphamt
reviewed
Dec 4, 2025
Shinu95J
requested review from
alphamt
and removed request for
abolfazl-alemi-aa
sounak98
requested changes
Dec 5, 2025
Contributor
sounak98
left a comment
sounak98
left a comment
There was a problem hiding this comment.
Consider renaming the Collection field in the client config to DefaultCollection. The current naming might give the impression that this client is tied to a single collection, rather than being a multi-collection client with a default.
Additionally, methods like Search, Delete, etc. should accept an optional collection parameter, falling back to DefaultCollection when not specified. This would make the multi-collection capability more explicit and flexible.
…ulti-collection capability
Shinu95J
changed the title
sounak98
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.