[O2-5295] DPL Analysis: introduce aod-writer-df-offset option#13541
[O2-5295] DPL Analysis: introduce aod-writer-df-offset option#13541aalkin wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
|
||
| itemName = "OutputDescriptors"; | ||
| if (dodirItem.HasMember(itemName)) { | ||
| std::string slh("/"); |
There was a problem hiding this comment.
The whole thing needs a refactoring pass, but it is not critical.
ktf
left a comment
ktf
left a comment
There was a problem hiding this comment.
Assuming it was tested, fine with me. We should get rid of the tuple in a subsequent PR, IMHO.
|
I just posted comments on the related JIRA ticket which may be relevant... The DF/TF number is internally available and some task may grab it and use it for something. In this case the number will be different in the file than during the current processing. Why we do not set it before generation? |
|
Discussion continues on https://its.cern.ch/jira/browse/O2-5295 |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
Replaced by #13711 |
4 participants
Introduces
--aod-writer-df-offset Noption that makes dataframes numbers start fromN+1. Can also be set in writer configuration JSON file as 'offset'.