Skip to content

[PWGEM] PhotonMeson: change more cutlibs to use concepts #14798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhemmer-cern merged 2 commits into from
Feb 4, 2026
+186 −33
Merged

[PWGEM] PhotonMeson: change more cutlibs to use concepts #14798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598928a
[PWGEM] PhotonMeson: change more cutlibs to use concepts
mhemmer-cern Feb 4, 2026
896777f
[PWGEM] PhotonMeson V0PhotonCuts.h
mhemmer-cern Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions PWGEM/PhotonMeson/Core/DalitzEECut.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "PWGEM/Dilepton/Utils/PairUtilities.h"

#include <CommonConstants/PhysicsConstants.h>
#include <Framework/ASoA.h>

#include <Math/Vector4D.h> // IWYU pragma: keep
#include <Math/Vector4Dfwd.h>
Expand Down Expand Up @@ -72,7 +73,7 @@ class DalitzEECut : public TNamed
kTPConly = 1,
};

template <typename TTrack1, typename TTrack2>
template <o2::soa::is_iterator TTrack1, o2::soa::is_iterator TTrack2>
bool IsSelected(TTrack1 const& t1, TTrack2 const& t2, float bz) const
{
if (!IsSelectedTrack(t1) || !IsSelectedTrack(t2)) {
Expand All @@ -86,7 +87,7 @@ class DalitzEECut : public TNamed
return true;
}

template <typename TTrack1, typename TTrack2>
template <o2::soa::is_iterator TTrack1, o2::soa::is_iterator TTrack2>
bool IsSelectedPair(TTrack1 const& t1, TTrack2 const& t2, const float bz) const
{
ROOT::Math::PtEtaPhiMVector v1(t1.pt(), t1.eta(), t1.phi(), o2::constants::physics::MassElectron);
Expand All @@ -108,7 +109,7 @@ class DalitzEECut : public TNamed
return true;
}

template <bool isML = false, typename TTrack, typename TCollision = int>
template <bool isML = false, o2::soa::is_iterator TTrack, typename TCollision = int>
bool IsSelectedTrack(TTrack const& track, TCollision const& = 0) const
{
if (!track.hasITS()) {
Expand Down Expand Up @@ -194,7 +195,7 @@ class DalitzEECut : public TNamed
return true;
}

template <typename T>
template <o2::soa::is_iterator T>
bool PassPID(T const& track) const
{
switch (mPIDScheme) {
Expand All @@ -212,15 +213,15 @@ class DalitzEECut : public TNamed
}
}

template <typename T>
template <o2::soa::is_iterator T>
bool PassTPConly(T const& track) const
{
bool is_el_included_TPC = mMinTPCNsigmaEl < track.tpcNSigmaEl() && track.tpcNSigmaEl() < mMaxTPCNsigmaEl;
bool is_pi_excluded_TPC = track.tpcNSigmaPi() < mMinTPCNsigmaPi || mMaxTPCNsigmaPi < track.tpcNSigmaPi();
return is_el_included_TPC && is_pi_excluded_TPC;
}

template <typename T>
template <o2::soa::is_iterator T>
bool PassTOFif(T const& track) const
{
bool is_el_included_TPC = mMinTPCNsigmaEl < track.tpcNSigmaEl() && track.tpcNSigmaEl() < mMaxTPCNsigmaEl;
Expand All @@ -229,7 +230,7 @@ class DalitzEECut : public TNamed
return is_el_included_TPC && is_pi_excluded_TPC && is_el_included_TOF;
}

template <typename T>
template <o2::soa::is_iterator T>
bool IsSelectedTrack(T const& track, const DalitzEECuts& cut) const
{
switch (cut) {
Expand Down
57 changes: 36 additions & 21 deletions PWGEM/PhotonMeson/Core/V0PhotonCut.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
#ifndef PWGEM_PHOTONMESON_CORE_V0PHOTONCUT_H_
#define PWGEM_PHOTONMESON_CORE_V0PHOTONCUT_H_

#include "PWGEM/PhotonMeson/Core/EMBitFlags.h"
#include "PWGEM/PhotonMeson/Core/EmMlResponsePCM.h"
#include "PWGEM/PhotonMeson/Core/V0PhotonCandidate.h"
#include "PWGEM/PhotonMeson/Utils/TrackSelection.h"

#include <CCDB/CcdbApi.h>
#include <CommonConstants/MathConstants.h>
#include <Framework/ASoA.h>
#include <Framework/Array2D.h>

Expand All @@ -40,8 +42,6 @@
#include <utility>
#include <vector>

using namespace o2::pwgem::photonmeson;

namespace o2::analysis
{

Expand Down Expand Up @@ -193,6 +193,21 @@ class V0PhotonCut : public TNamed
kNCuts
};

/// \brief check if given v0 photon survives all cuts
/// \param flags EMBitFlags where results will be stored
/// \param v0s v0 photon table to check
template <o2::soa::is_table TV0, typename TLeg>
void AreSelectedRunning(EMBitFlags& flags, TV0 const& v0s) const
{
size_t iV0 = 0;
for (const auto& v0 : v0s) {
if (!IsSelected<decltype(v0), TLeg>(v0)) {
flags.set(iV0);
}
++iV0;
}
}

template <o2::soa::is_iterator TV0, typename TLeg>
bool IsSelected(TV0 const& v0) const
{
Expand Down Expand Up @@ -247,7 +262,7 @@ class V0PhotonCut : public TNamed
auto pos = v0.template posTrack_as<TLeg>();
auto ele = v0.template negTrack_as<TLeg>();

for (auto& track : {pos, ele}) {
for (const auto& track : {pos, ele}) {
if (!IsSelectedTrack(track, V0PhotonCuts::kTrackPtRange)) {
return false;
}
Expand All @@ -263,24 +278,24 @@ class V0PhotonCut : public TNamed
if (!track.hasITS() && !track.hasTPC()) { // track has to be ITSonly or TPConly or ITS-TPC
return false;
}
if (mDisableITSonly && isITSonlyTrack(track)) {
if (mDisableITSonly && o2::pwgem::photonmeson::isITSonlyTrack(track)) {
return false;
}
if (mDisableTPConly && isTPConlyTrack(track)) {
if (mDisableTPConly && o2::pwgem::photonmeson::isTPConlyTrack(track)) {
return false;
}

if (mRejectITSib) {
auto hits_ib = std::count_if(its_ib_Requirement.second.begin(), its_ib_Requirement.second.end(), [&](auto&& requiredLayer) { return track.itsClusterMap() & (1 << requiredLayer); });
auto hits_ob = std::count_if(its_ob_Requirement.second.begin(), its_ob_Requirement.second.end(), [&](auto&& requiredLayer) { return track.itsClusterMap() & (1 << requiredLayer); });
bool its_ob_only = (hits_ib <= its_ib_Requirement.first) && (hits_ob >= its_ob_Requirement.first);
if (isITSonlyTrack(track) && !its_ob_only) { // ITSonly tracks should not have any ITSib hits.
if (o2::pwgem::photonmeson::isITSonlyTrack(track) && !its_ob_only) { // ITSonly tracks should not have any ITSib hits.
return false;
}

auto hits_ob_itstpc = std::count_if(its_ob_Requirement_ITSTPC.second.begin(), its_ob_Requirement_ITSTPC.second.end(), [&](auto&& requiredLayer) { return track.itsClusterMap() & (1 << requiredLayer); });
bool its_ob_only_itstpc = (hits_ib <= its_ib_Requirement.first) && (hits_ob_itstpc >= its_ob_Requirement_ITSTPC.first);
if (isITSTPCTrack(track) && !its_ob_only_itstpc) { // ITSTPC tracks should not have any ITSib hits.
if (o2::pwgem::photonmeson::isITSTPCTrack(track) && !its_ob_only_itstpc) { // ITSTPC tracks should not have any ITSib hits.
return false;
}
}
Expand Down Expand Up @@ -400,7 +415,7 @@ class V0PhotonCut : public TNamed
return v0.mGamma() < mMaxQt * 2.f;

case V0PhotonCuts::kAP:
return pow(v0.alpha() / mMaxAlpha, 2) + pow(v0.qtarm() / mMaxQt, 2) < 1.0;
return std::pow(v0.alpha() / mMaxAlpha, 2) + std::pow(v0.qtarm() / mMaxQt, 2) < 1.0;

case V0PhotonCuts::kPsiPair:
return true;
Expand Down Expand Up @@ -438,24 +453,24 @@ class V0PhotonCut : public TNamed
float y = v0.vy(); // cm, measured secondary vertex of gamma->ee
float z = v0.vz(); // cm, measured secondary vertex of gamma->ee

float rxy = sqrt(x * x + y * y);
float rxy = std::sqrt(x * x + y * y);
if (rxy < 7.0 || 14.0 < rxy) {
return false;
}

// r = 0.192 * z + 8.88 (cm) expected wire position in RZ plane.TMath::Tan(10.86 * TMath::DegToRad()) = 0.192
// r = 0.192 * z + 8.88 (cm) expected wire position in RZ plane.TMath::Tan(10.86 * o2::constants::math::Deg2Rad) = 0.192
if (rxy > 0.192 * z + 14.0) { // upper limit
return false;
}

float dxy = std::fabs(1.0 * y - x * std::tan(-8.52 * TMath::DegToRad())) / sqrt(pow(1.0, 2) + pow(std::tan(-8.52 * TMath::DegToRad()), 2));
float dxy = std::fabs(1.0 * y - x * std::tan(-8.52f * o2::constants::math::Deg2Rad)) / std::sqrt(std::pow(1.0, 2) + std::pow(std::tan(-8.52f * o2::constants::math::Deg2Rad), 2));
return !(dxy > margin_xy);
}
case V0PhotonCuts::kOnWwireOB: {
const float margin_xy = 1.0; // cm
const float rxy_exp = 30.8; // cm
const float x_exp = rxy_exp * std::cos(-1.3 * TMath::DegToRad()); // cm, expected position x of W wire
const float y_exp = rxy_exp * std::sin(-1.3 * TMath::DegToRad()); // cm, expected position y of W wire
const float margin_xy = 1.0; // cm
const float rxy_exp = 30.8; // cm
const float x_exp = rxy_exp * std::cos(-1.3f * o2::constants::math::Deg2Rad); // cm, expected position x of W wire
const float y_exp = rxy_exp * std::sin(-1.3f * o2::constants::math::Deg2Rad); // cm, expected position y of W wire
// const float z_min = -47.0; // cm
// const float z_max = +47.0; // cm
float x = v0.vx(); // cm, measured secondary vertex of gamma->ee
Expand Down Expand Up @@ -520,26 +535,26 @@ class V0PhotonCut : public TNamed
return mMinChi2PerClusterITS < track.itsChi2NCl() && track.itsChi2NCl() < mMaxChi2PerClusterITS;

case V0PhotonCuts::kITSClusterSize: {
if (!isITSonlyTrack(track)) {
if (!o2::pwgem::photonmeson::isITSonlyTrack(track)) {
return true;
}
return mMinMeanClusterSizeITS < track.meanClusterSizeITSob() * std::cos(std::atan(track.tgl())) && track.meanClusterSizeITSob() * std::cos(std::atan(track.tgl())) < mMaxMeanClusterSizeITS;
}

case V0PhotonCuts::kRequireITSTPC:
return isITSTPCTrack(track);
return o2::pwgem::photonmeson::isITSTPCTrack(track);

case V0PhotonCuts::kRequireITSonly:
return isITSonlyTrack(track);
return o2::pwgem::photonmeson::isITSonlyTrack(track);

case V0PhotonCuts::kRequireTPConly:
return isTPConlyTrack(track);
return o2::pwgem::photonmeson::isTPConlyTrack(track);

case V0PhotonCuts::kRequireTPCTRD:
return isTPCTRDTrack(track);
return o2::pwgem::photonmeson::isTPCTRDTrack(track);

case V0PhotonCuts::kRequireTPCTOF:
return isTPCTOFTrack(track);
return o2::pwgem::photonmeson::isTPCTOFTrack(track);

default:
return false;
Expand Down
Loading
Loading