Skip to content

Conversation

@partykyoung
Copy link

 ● Test suite failed to run
    SecurityError: localStorage is not available for opaque origins
      
      at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
      at Array.forEach (native)

I saw this error message, So I looked for a way to fix this error and found this link and added testUrl to package.json.

jsdom/jsdom#2304

@Aljullu
Copy link
Owner

Aljullu commented Aug 4, 2018

Hi @partykyoung, thanks for working on this! I think we should merge this PR first and merge the other one later.

A couple of comments about this PR:

  • I see there are some changes in the file LazyLoadImage.jsx which I think they don't belong in this PR. Could you undo those changes?

  • Actually, looking at the commit history it's a bit messy, I think this change should be implemented in one single commit instead of six like it's now. :)

If you agree with me, I would proceed like this: create a new branch directly from master and implement the changes in package.json and LazyLoadImage.spec.js from this PR. Then, create the PR with those changes.

In another branch, also forked from master, I would implement the changes from #3, which were already looking fine. :)

@partykyoung
Copy link
Author

@Aljullu
I thought LazyLoadImage.jsx had nothing to do with jest configuration, so I rollbacked it at this branch.

I agree with your comment.

@Aljullu
Copy link
Owner

Aljullu commented Aug 20, 2018

@partykyoung did you have time to take a look at this? Let me know if you have any issues with the proposed solution or need any help and i will kindly support you!

@Aljullu Aljullu mentioned this pull request Aug 22, 2018
@Aljullu
Copy link
Owner

Aljullu commented Aug 22, 2018

I'm gonna proceed closing this PR because I implemented the changes in #5, I wanted to get it merged fast because builds were failing. But thanks for working on this @partykyoung! 🙂

@Aljullu Aljullu closed this Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants