Skip to content

Conversation

@ROCKTAKEY
Copy link

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality that this introduces.

Add a new configuration variable, runtime_extra_volumes which means extra volumes for bind mounts.
We can bind-mount the host directory in the sandbox container by setting it.
It is useful for Docker outside of Docker since it let us mount /var/run/docker.sock on the sandbox.


Give a summary of what the PR does, explaining any non-trivial design decisions.

Add a new configuration variable, runtime_extra_volumes and add document for it.


Link of any specific issues this addresses.

None

@ROCKTAKEY ROCKTAKEY force-pushed the runtime-extra-volumes branch from 4bbeb00 to 2f5a423 Compare March 27, 2025 17:07
@ROCKTAKEY ROCKTAKEY force-pushed the runtime-extra-volumes branch from 2f5a423 to ca7b0b9 Compare March 27, 2025 17:08
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the introduced type error, this looks like a solid change. It should be noted that we have moved away from a mounted volume by default.

@ROCKTAKEY
Copy link
Author

@tofarr Thanks for your review. Fix the typing issue.

It should be noted that we have moved away from a mounted volume by default.

I am confused. It means the runtime container does not use mounted volume as workspace, isn't it?

@ROCKTAKEY ROCKTAKEY requested a review from tofarr April 16, 2025 15:06
@hamiltop
Copy link
Contributor

There's no issue to 👍 , but I want to chime in and say this would solve many issues for us. Beyond docker in docker, we also would mount a dependency cache volume so we can re-use the outputs of things like bundle install across sandboxes, speeding up setup time significantly.

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 🍰

@tofarr I think your concern has been addressed, could you take a look?

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Inactive for 40 days label May 22, 2025
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for over 30 days with no activity.

@github-actions github-actions bot closed this May 29, 2025
@enyst
Copy link
Collaborator

enyst commented May 29, 2025

@ROCKTAKEY I apologize for us dropping the ball here. We could have handled this differently, and I promise I'll try to fix our process.

In the meantime, another PR implemented this slightly differently, in the sandbox section, and this feature is released. Thank you for the contribution, and I'm really sorry for the miss!

@ROCKTAKEY
Copy link
Author

ROCKTAKEY commented May 29, 2025

@enyst Never mind. I'm glad it was implemented.

I will show the functions implemented for someone who needs the feature: SANDBOX_VOLUMES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Inactive for 40 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants