-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add return type annotations to docker runtime #8543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update mypy configuration with stricter type checking rules - Add more type stubs to pre-commit configuration - Run mypy both through pre-commit and directly in CI - Install project in editable mode for better type checking - Set correct PYTHONPATH in CI environment
Co-authored-by: openhands <openhands@all-hands.dev>
|
LGTM, this is ready for review. |
|
@OpenHands please fix merge conflicts |
|
I'm on it! neubig can track my progress at all-hands.dev |
|
I've successfully fixed the merge conflicts in the docker-typing-improvements branch for PR #8543. Here's what I did:
The PR is now mergeable according to GitHub's API. The changes maintain the purpose of the PR (adding return type annotations) while incorporating the method name changes from the main branch. The changes have been successfully pushed to the remote branch, and the PR has been updated. |
|
This is ready for review. |
|
@OpenHands think carefully and resolve merge conflicts |
|
I'm on it! neubig can track my progress at all-hands.dev |
|
I successfully resolved the merge conflicts in the docker-typing-improvements branch (PR #8543). Here's a summary of what I did:
The PR should now be updated with the resolved merge conflicts, maintaining both the type annotations from our branch and the app port environment variables from the main branch. |
Co-authored-by: openhands <openhands@all-hands.dev>
This PR adds return type annotations to the docker runtime implementation in the openhands/runtime/impl/docker directory. It addresses the mypy errors in this directory as part of the strict-mypy-checks feature.
To run this PR locally, use the following command: