[WIP] OH Versa #8598
[WIP] OH Versa #8598
Conversation
… use when providing context to the LLM.
…sary (#6618) Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Xingyao Wang <xingyao6@illinois.edu>
…dates (#6617) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>
Co-authored-by: sp.wack <83104063+amanape@users.noreply.github.com>
Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: Ray Myers <ray.myers@gmail.com>
…rowsing tool single-action
This reverts commit 2f999ce.
| _SEARCH_ENGINE_DESCRIPTION = """Execute a web search query (similar to Google search). | ||
| You MUST use this tool as a search engine and find URLs of webpages that are relevant to the search query. | ||
| NOTE: Do NOT use the browser tool to search using Google or Bing since you will be blocked by CAPTCHAs. |
There was a problem hiding this comment.
| NOTE: Do NOT use the browser tool to search using Google or Bing since you will be blocked by CAPTCHAs. | |
| NOTE: Do NOT use the search engine tool to search using Google or Bing since you will be blocked by CAPTCHAs. |
|
Blocked by: All-Hands-AI/openhands-aci#126 |
| obs, reward, terminated, truncated, info = env.step(action) | ||
| try: | ||
| obs, reward, terminated, truncated, info = env.step(action) | ||
| except Exception as e: |
There was a problem hiding this comment.
Does this error handling code serve any special purpose? I think BrowserGym's step implementation already has it own error handling: https://github.com/ServiceNow/BrowserGym/blob/6bc4c5156d32d7c6598ea376badc5ff79030fe5b/browsergym/core/src/browsergym/core/env.py#L458-L462
There was a problem hiding this comment.
This addition is intentional and not just for extra safety. Firstly, there are some cases in browsergym 0.10.2 wherein the step function raises an error (I guess these don't happen for version 0.13.3) especially when there is an error during processing of AXTree (see here - an error saying Cannot mark child frame without bid)
Also it is better to have this line in the code - the browser_process function runs inside a separate process, and if it crashes/exits due to some reason, the main OpenHands process running the step function (the client side) will always face timeouts, and all subsequent browsing actions will fail since the server side (browser_process) has exited silently.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
These are already merged in separate PRs. Close this. |
20 participants
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Link of any specific issues this addresses: