Skip to content

Bugfix/sweep formula assert out on invalid data range #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-b merged 2 commits into from
Jul 21, 2020
Merged

Bugfix/sweep formula assert out on invalid data range #577

t-b merged 2 commits into from
Jul 21, 2020

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Jul 20, 2020

Successor of #561.

t-b added 2 commits July 16, 2020 00:18
@t-b
Packages/MIES/MIES_SweepFormula.ipf: Assert out on invalid sweep range
c3b5219 
If the range for the data function is not completely inside the given
sweeps we currently return bogus data.

Let's assert out instead as this is more correct.

This has yet to use proper error handling, but that will be not part
of this commit.

Closes #468.
@t-b
Tests: Make STIW_TestDimensions pass again
efcd75f 
ScaleToIndex was rectified in egde cases in latest IP8 nightly.
@t-b t-b requested a review from timjarsky as a code owner July 20, 2020 20:46
@timjarsky timjarsky assigned t-b and unassigned timjarsky Jul 21, 2020
@t-b t-b merged commit d98ac2e into main Jul 21, 2020
@t-b t-b deleted the bugfix/sweep-formula-assert-out-on-invalid-data-range branch July 21, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timjarsky timjarsky timjarsky approved these changes

Assignees

@t-b t-b

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-b @timjarsky