Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/features/applicationMetadata/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ export interface IPartyTypesAllowed {

export interface IBackendFeaturesState {
jsonObjectInDataResponse: boolean; // Extended attachment validation
addInstanceIdentifierToLayoutRequests: boolean; // Add instance identifier to layout requests
}
16 changes: 14 additions & 2 deletions src/features/form/layout/LayoutsContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,17 @@ import { useAppQueries } from 'src/core/contexts/AppQueriesProvider';
import { ContextNotProvided } from 'src/core/contexts/context';
import { delayedContext } from 'src/core/contexts/delayedContext';
import { createQueryContext } from 'src/core/contexts/queryContext';
import { useApplicationMetadata } from 'src/features/applicationMetadata/ApplicationMetadataProvider';
import { useCurrentDataModelName } from 'src/features/datamodel/useBindingSchema';
import { cleanLayout } from 'src/features/form/layout/cleanLayout';
import { makeLayoutLookups } from 'src/features/form/layout/makeLayoutLookups';
import { applyLayoutQuirks } from 'src/features/form/layout/quirks';
import { useLayoutSets } from 'src/features/form/layoutSets/LayoutSetsProvider';
import { useLayoutSetIdFromUrl } from 'src/features/form/layoutSets/useCurrentLayoutSet';
import { useInstanceDataQuery } from 'src/features/instance/InstanceContext';
import { useInstanceDataQuery, useLaxInstanceId } from 'src/features/instance/InstanceContext';
import { useProcessQuery } from 'src/features/instance/useProcessQuery';
import { makeLikertChildId } from 'src/layout/Likert/Generator/makeLikertChildId';
import { fetchLayoutsForInstance } from 'src/queries/queries';
import type { QueryDefinition } from 'src/core/queries/usePrefetchQuery';
import type { CompExternal, ILayoutCollection, ILayouts } from 'src/layout/layout';
import type { IExpandedWidthLayouts, IHiddenLayoutsExternal } from 'src/types';
Expand All @@ -32,10 +34,20 @@ export function useLayoutQueryDef(
layoutSetId?: string,
): QueryDefinition<LayoutContextValue> {
const { fetchLayouts } = useAppQueries();
const instanceId = useLaxInstanceId();
const features = useApplicationMetadata().features ?? {};

return {
queryKey: ['formLayouts', layoutSetId, enabled],
queryFn: layoutSetId
? () => fetchLayouts(layoutSetId).then((layouts) => processLayouts(layouts, layoutSetId, defaultDataModelType))
? async () => {
const shouldUseInstanceEndpoint = features.addInstanceIdentifierToLayoutRequests && instanceId;
const layouts = shouldUseInstanceEndpoint
? await fetchLayoutsForInstance(layoutSetId, instanceId)
: await fetchLayouts(layoutSetId);

return processLayouts(layouts, layoutSetId, defaultDataModelType);
}
: skipToken,
enabled: enabled && !!layoutSetId,
};
Expand Down
4 changes: 4 additions & 0 deletions src/queries/queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
getFileUploadUrl,
getFileUploadUrlOld,
getFooterLayoutUrl,
getInstanceLayoutsUrl,
getInstantiateUrl,
getJsonSchemaUrl,
getLayoutSetsUrl,
Expand Down Expand Up @@ -292,6 +293,9 @@ export const fetchLayoutSets = (): Promise<ILayoutSets> => httpGet(getLayoutSets

export const fetchLayouts = (layoutSetId: string): Promise<ILayoutCollection> => httpGet(getLayoutsUrl(layoutSetId));

export const fetchLayoutsForInstance = (layoutSetId: string, instanceId: string): Promise<ILayoutCollection> =>
httpGet(getInstanceLayoutsUrl(layoutSetId, instanceId));

export const fetchLayoutSettings = (layoutSetId: string): Promise<ILayoutSettings> =>
httpGet(getLayoutSettingsUrl(layoutSetId));

Expand Down
1 change: 1 addition & 0 deletions src/test/renderWithProviders.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ const defaultQueryMocks: AppQueries = {
fetchPostPlace: async () => ({ valid: true, result: 'OSLO' }),
fetchLayoutSettings: async () => ({ pages: { order: [] } }),
fetchLayouts: () => Promise.reject(new Error('fetchLayouts not mocked')),
fetchLayoutsForInstance: () => Promise.reject(new Error('fetchLayoutsForInstance not mocked')),
fetchBackendValidations: async () => [],
fetchBackendValidationsForDataElement: async () => [],
fetchPaymentInformation: async () => paymentResponsePayload,
Expand Down
8 changes: 8 additions & 0 deletions src/utils/urls/appUrlHelper.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
getEnvironmentLoginUrl,
getFetchFormDynamicsUrl,
getHostname,
getInstanceLayoutsUrl,
getInstantiateUrl,
getLayoutSettingsUrl,
getLayoutsUrl,
Expand Down Expand Up @@ -379,6 +380,13 @@ describe('Frontend urlHelper.ts', () => {
});
});

describe('getInstanceLayoutsUrl', () => {
it('should include instance ID in layout URL when provided', () => {
const result = getInstanceLayoutsUrl('custom-layout.json', 'instanceId-1234');
expect(result).toBe('https://local.altinn.cloud/ttd/test/instances/instanceId-1234/layouts/custom-layout.json');
});
});

describe('getLayoutSettingsUrl', () => {
it('should return layout as passed argument', () => {
const result = getLayoutSettingsUrl('custom-layout.json');
Expand Down
2 changes: 2 additions & 0 deletions src/utils/urls/appUrlHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ export const getLayoutSetsUrl = () => `${appPath}/api/layoutsets`;
export const getFooterLayoutUrl = () => `${appPath}/api/v1/footer`;
export const getFetchFormDynamicsUrl = (layoutSetId: string) => `${appPath}/api/ruleconfiguration/${layoutSetId}`;
export const getLayoutsUrl = (layoutSetId: string) => `${appPath}/api/layouts/${layoutSetId}`;
export const getInstanceLayoutsUrl = (layoutSetId: string, instanceId: string) =>
`${appPath}/instances/${instanceId}/layouts/${layoutSetId}`;
export const getRulehandlerUrl = (layoutSet: string) => `${appPath}/api/rulehandler/${layoutSet}`;
export const getActiveInstancesUrl = (partyId: number) => `${appPath}/instances/${partyId}/active`;
export const getInstanceUiUrl = (instanceId: string) => `${appPath}#/instance/${instanceId}`;
Expand Down