-
Notifications
You must be signed in to change notification settings - Fork 46
feat: video player integration #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: video player integration #10
Conversation
|
Hey @giolaq, I've set up a draft PR to integrate the video player. Could you take a look when you have a chance and let me know what you think? |
|
Hi @moskalakamil ! This is great, I was actually thinking to add a proper video player screen. Feel free to add on this PR! 🔝 |
|
Hey! @giolaq 👋 I've implemented the changes I described earlier - sorry it took a bit longer, but I got it done! :)) Additionally, I have a suggestion that could be an interesting addition to this project. As maintainers of react-native-video, we’ve been working on some video examples, including support for DRM-protected content. We created a component where the user pastes a token generated by a form, and once it's added, everything works smoothly (you can find the example here: DRMExample.tsx). We haven’t fully completed this yet, but we’re almost there. I was thinking it might be worth considering adding even one video with DRM support to your app. Applications like yours often leverage this kind of mechanism, so it could be a cool way to expand functionality and compatibility with more advanced playback scenarios. Let me know what you think! 😊 |
|
Thank you @moskalakamil ! It looks great, the only thing with this app we want to support even the web-based TVs. Any idea about how to support the video player also in this case? I totally like the idea to support DRM! |
|
I get it, I’ll come back with an answer tomorrow |
|
Thank you! |
|
I need a little more time to fully sort this out; I'll get back to you asap |
|
Hi @giolaq, we are planning to add basic web support for react-native-video soon, and I'll keep you updated once it's live. In the meantime, we just finished implementing the DRM logic for our example today, so you can check it out to see how it looks in RNV repo |
|
Amazing thank you! |
|
Hi @giolaq, good news! Web support is working now as well |
|
Thank you @moskalakamil! Amazing work |
|
Thank you 🙌 |
Feature: Video Player Integration
This PR implements a video player for the app.
Changes:
mainanddetailsscreens.playerscreen.Testing:
yarn installin the root directory.yarn android --devicesand select a TV device.yarn ios.I've even tested it on Fire TV! :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.