-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Cleanup LICENSE.md completed #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LICENSE.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just upgraded, so this is actually 2015 now.
|
Just those 2 comments. Thanks @eputnam! |
|
@eputnam let us know if you are able to make these changes today, and then we would be able to release this with Cesium 1.16 tomorrow. |
|
@pjcozzi , so sorry, i will get these in today. |
|
Awesome, thanks @eputnam! |
|
I'll go back over everything and make sure I've got the info right based on the packages' copyright info, not what's in the Cesium stuff. |
|
@eputnam is this ready now? I see you made a commit to this branch. |
|
yep! sorry for any confusion, guys. this is my first contribution ever. in On Wed, Dec 2, 2015 at 11:28 AM, Patrick Cozzi notifications@github.com
|
|
No worries @eputnam. Usually when any review comments have been address, it's good to add a "ready" message so that we know to look at it again. Otherwise we might merge it before you're done with whatever changes you wanted to make. In this case, this looks great and congratulations on your first contribution in the universe. Hopefully one of many! |
Wow, very cool. Thanks for the contribution! What do you want to do next? :) https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#getting-started-contributing-code-and-documentation By the way, are you also @eputnam on twitter? |
Completed cleanup of LICENSE.md. This is ready.