Skip to content

Conversation

@eputnam
Copy link
Contributor

@eputnam eputnam commented Nov 21, 2015

Completed cleanup of LICENSE.md. This is ready.

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 23, 2015

Thanks @eputnam!

@mramato do you want to review this? Or should I?

LICENSE.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just upgraded, so this is actually 2015 now.

@mramato
Copy link
Contributor

mramato commented Nov 23, 2015

Just those 2 comments. Thanks @eputnam!

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 30, 2015

@eputnam let us know if you are able to make these changes today, and then we would be able to release this with Cesium 1.16 tomorrow.

@eputnam
Copy link
Contributor Author

eputnam commented Nov 30, 2015

@pjcozzi , so sorry, i will get these in today.

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 30, 2015

Awesome, thanks @eputnam!

@eputnam
Copy link
Contributor Author

eputnam commented Nov 30, 2015

I'll go back over everything and make sure I've got the info right based on the packages' copyright info, not what's in the Cesium stuff.

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 2, 2015

@eputnam is this ready now? I see you made a commit to this branch.

@eputnam
Copy link
Contributor Author

eputnam commented Dec 2, 2015

yep! sorry for any confusion, guys. this is my first contribution ever. in
the universe.

On Wed, Dec 2, 2015 at 11:28 AM, Patrick Cozzi notifications@github.com
wrote:

@eputnam https://github.com/eputnam is this ready now? I see you made a
commit to this branch.


Reply to this email directly or view it on GitHub
#3235 (comment)
.

@mramato
Copy link
Contributor

mramato commented Dec 2, 2015

No worries @eputnam. Usually when any review comments have been address, it's good to add a "ready" message so that we know to look at it again. Otherwise we might merge it before you're done with whatever changes you wanted to make. In this case, this looks great and congratulations on your first contribution in the universe. Hopefully one of many!

mramato added a commit that referenced this pull request Dec 2, 2015
Cleanup LICENSE.md completed
@mramato mramato merged commit d61d7a9 into CesiumGS:master Dec 2, 2015
@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 2, 2015

yep! sorry for any confusion, guys. this is my first contribution ever. in the universe.

Wow, very cool. Thanks for the contribution! What do you want to do next? :) https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#getting-started-contributing-code-and-documentation

By the way, are you also @eputnam on twitter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants