Anchors, Buttons and Icon Handling#2
Conversation
wintondeshong
commented
Jul 15, 2020
wintondeshong
commented
- n/a Related GitHub issue(s) linked in PR description
- Destination branch merged, built and tested with your changes
- Code formatted and follows best practices and patterns
- Code builds cleanly (no additional warnings or errors)
- Manually tested
- Automated tests are passing
- No decreases in automated test coverage
- Documentation updated (readme, docs, comments, etc.)
- n/a Localization: No hard-coded error messages in code files (minimally in string constants)
- New component and/ or properties? Make sure to update storybook
| }); | ||
| }); | ||
|
|
||
| it("when accessibleText provided, renders child accessible span", () => { |
There was a problem hiding this comment.
Nitpick - since these props are inputs passed to the component (not a precondition of the test or component setup), would given accessibleText ... make more sense?
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
============================================
+ Coverage 13.33% 100.00% +86.66%
============================================
Files 10 5 -5
Lines 105 58 -47
Branches 22 18 -4
============================================
+ Hits 14 58 +44
+ Misses 90 0 -90
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
|
@all-contributors add @wintondeshong for code, doc, test |
|
I've put up a pull request to add @wintondeshong! 🎉 |
|
@all-contributors add @jhugs for review |
|
I've put up a pull request to add @jhugs! 🎉 |
|
@all-contributors add @brandongregoryscott for review |
|
I've put up a pull request to add @brandongregoryscott! 🎉 |
3 participants
