Skip to content

SCSS for existing components#3

Merged
wintondeshong merged 3 commits intorsm-hcd:masterfrom
wintondeshong:master
Jul 16, 2020
Merged

SCSS for existing components#3
wintondeshong merged 3 commits intorsm-hcd:masterfrom
wintondeshong:master

Conversation

@wintondeshong
Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong commented Jul 16, 2020 •
edited
Loading

Ported ITSCSS SCSS structure for existing atom components

  • n/a Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • n/a No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • n/a Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

@wintondeshong wintondeshong self-assigned this Jul 16, 2020
@wintondeshong wintondeshong added the enhancement New feature or request label Jul 16, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           58        58           
  Branches        18        18           
=========================================
  Hits            58        58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6779a...8700b46. Read the comment docs.

@wintondeshong wintondeshong marked this pull request as ready for review July 16, 2020 14:11
brandongregoryscott
brandongregoryscott approved these changes Jul 16, 2020
View reviewed changes
Comment thread src/assets/scss/andculturecode-javascript-react-components.scss Outdated
jebediahelliott
jebediahelliott approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown

@jebediahelliott jebediahelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left one comment about the button styling. More of a curiosity than anything else

Comment thread src/assets/scss/6-components/atoms/_buttons.scss Outdated
@wintondeshong wintondeshong merged commit 74a7971 into rsm-hcd:master Jul 16, 2020
@brandongregoryscott
Copy link
Copy Markdown
Contributor

brandongregoryscott commented May 17, 2021

@all-contributors add @jebediahelliott for review

@allcontributors allcontributors Bot mentioned this pull request May 17, 2021
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented May 17, 2021

@brandongregoryscott

I've put up a pull request to add @jebediahelliott! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stefanie899 Stefanie899 Awaiting requested review from Stefanie899

3 more reviewers

@brandongregoryscott brandongregoryscott brandongregoryscott approved these changes

@jhugs jhugs jhugs approved these changes

@jebediahelliott jebediahelliott jebediahelliott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wintondeshong wintondeshong

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wintondeshong @brandongregoryscott @jhugs @jebediahelliott