Can we use JIT snippet loading? #252
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that yasnippet now supports JIT snippet loading. Can we make this the default setting when we initialize snippets? From some very basic benchmarking this reduces my load time of yasnippet-snippet autoloads from ~2200 ms to ~400 ms. Further compiling the snippets pushes this down to ~360 ms.
Owner
|
Ah yes absolutely, I didn't know about this option. |
Contributor
|
Jit-loading has been around for a while. joaotavora/yasnippet@922304f reversed the sense of the parameter, but that was before 0.8.0 (which you're already requiring as a minimum) so there's no problem from a versioning perspective. |
Owner
|
Ah that's good to hear, no reason not to merge it for me then, thank you both |
Contributor
Author
|
Thanks! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that yasnippet now supports JIT snippet loading. Can we make this the default setting when we initialize snippets? From some very basic benchmarking this reduces my load time of yasnippet-snippet autoloads from ~2200 ms to ~400 ms. Further compiling the snippets pushes this down to ~360 ms.